Fixes for manager becoming stale#683
Merged
spentacular merged 4 commits intomainfrom Jul 11, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
=======================================
Coverage 90.36% 90.37%
=======================================
Files 333 333
Lines 20656 20703 +47
Branches 2011 2016 +5
=======================================
+ Hits 18666 18710 +44
- Misses 1974 1977 +3
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can you write releases notes for this? |
KetanReddy
approved these changes
Jul 11, 2025
Member
Author
|
/canary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Changes to the manager didn't cause the Managed Player to use the new manager because the subscription was only based on the initial Manager. This fixes a few details of the previous implementation:
terminateis calleduseSyncExternalStoreso they will still update outside ofuseEffectpatchminormajorN/ARelease Notes
Updates to the React Managed Player to ensure updates to the
managerterminate the running instance and start a brand new instance.📦 Published PR as canary version:
0.12.1--canary.683.24491Try this version out locally by upgrading relevant packages to 0.12.1--canary.683.24491