Skip to content

Fixes for manager becoming stale#683

Merged
spentacular merged 4 commits intomainfrom
stale-manager
Jul 11, 2025
Merged

Fixes for manager becoming stale#683
spentacular merged 4 commits intomainfrom
stale-manager

Conversation

@spentacular
Copy link
Copy Markdown
Member

@spentacular spentacular commented Jul 11, 2025

Change Type (required)

Changes to the manager didn't cause the Managed Player to use the new manager because the subscription was only based on the initial Manager. This fixes a few details of the previous implementation:

  1. Updates to the manager cause a new manager to be generated and persisted with a new key
  2. Before the manager changes, if the previous instance was still running, terminate is called
  3. Manager subscriptions now use useSyncExternalStore so they will still update outside of useEffect
  4. New manager is always started instead of that being in an effect
  • patch
  • minor
  • major
  • N/A

Release Notes

Updates to the React Managed Player to ensure updates to the manager terminate the running instance and start a brand new instance.

📦 Published PR as canary version: 0.12.1--canary.683.24491

Try this version out locally by upgrading relevant packages to 0.12.1--canary.683.24491

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (83ca324) to head (758b443).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
react/player/src/manager/managed-player.tsx 96.92% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   90.36%   90.37%           
=======================================
  Files         333      333           
  Lines       20656    20703   +47     
  Branches     2011     2016    +5     
=======================================
+ Hits        18666    18710   +44     
- Misses       1974     1977    +3     
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spentacular spentacular marked this pull request as ready for review July 11, 2025 19:19
@spentacular spentacular requested review from a team as code owners July 11, 2025 19:19
@KetanReddy
Copy link
Copy Markdown
Member

Can you write releases notes for this?

@spentacular
Copy link
Copy Markdown
Member Author

/canary

@spentacular spentacular merged commit 629330d into main Jul 11, 2025
11 checks passed
@spentacular spentacular deleted the stale-manager branch July 11, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants