Skip to content

fix iOS ManagedPlayerViewModel memory leak#688

Merged
cehan-Chloe merged 1 commit intomainfrom
ios-managedplayerviewmodel-memory-leak
Jul 16, 2025
Merged

fix iOS ManagedPlayerViewModel memory leak#688
cehan-Chloe merged 1 commit intomainfrom
ios-managedplayerviewmodel-memory-leak

Conversation

@cehan-Chloe
Copy link
Copy Markdown
Contributor

@cehan-Chloe cehan-Chloe commented Jul 15, 2025

Fix ManagedPlayerViewModel memory leak by adding weak self

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (629330d) to head (4911a59).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   90.37%   90.05%   -0.33%     
==========================================
  Files         333      334       +1     
  Lines       20703    21017     +314     
  Branches     2016     2104      +88     
==========================================
+ Hits        18710    18926     +216     
- Misses       1977     2073      +96     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cehan-Chloe cehan-Chloe marked this pull request as ready for review July 16, 2025 14:29
@cehan-Chloe cehan-Chloe requested a review from a team as a code owner July 16, 2025 14:29
@cehan-Chloe cehan-Chloe merged commit d686342 into main Jul 16, 2025
10 of 11 checks passed
@cehan-Chloe cehan-Chloe deleted the ios-managedplayerviewmodel-memory-leak branch July 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants