remove DefaultViewPlugins and move implementation into ViewController#689
Merged
remove DefaultViewPlugins and move implementation into ViewController#689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 334 333 -1
Lines 21017 21012 -5
Branches 2104 2101 -3
=======================================
- Hits 18926 18923 -3
+ Misses 2073 2071 -2
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KetanReddy
reviewed
Jul 16, 2025
KetanReddy
reviewed
Jul 16, 2025
| } | ||
| } | ||
|
|
||
| private createViewPlugins(): Array<ViewPlugin> { |
Member
There was a problem hiding this comment.
Can this function just apply the plugins?
Contributor
Author
There was a problem hiding this comment.
Apply needs to happen on during the onView instance whenever a new ViewInstance is created. If we want to only construct the plugins once and apply them to each view then we need to just create them first. If we're okay with constructing and applying them each time then I can make just one function to do both.
KetanReddy
reviewed
Jul 16, 2025
b4bb79f to
6af507e
Compare
Contributor
Author
|
/canary |
KetanReddy
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultViewPluginsViewControllerand ensure they get added before thethis.hooks.viewis calledChange Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
DefaultViewPluginsand add all plugins it uses into theViewControllerViewControllerandViewInstance📦 Published PR as canary version:
0.12.1--canary.689.24630Try this version out locally by upgrading relevant packages to 0.12.1--canary.689.24630