Skip to content

Fix ASYNC_ACTION Expressions Being Fired Multiple Times#691

Merged
KetanReddy merged 9 commits intomainfrom
bugfix/async-multifire
Jul 24, 2025
Merged

Fix ASYNC_ACTION Expressions Being Fired Multiple Times#691
KetanReddy merged 9 commits intomainfrom
bugfix/async-multifire

Conversation

@KetanReddy
Copy link
Copy Markdown
Member

@KetanReddy KetanReddy commented Jul 23, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

Fix Issue with awaited ASYNC_ACTION state's expressions being fired multiple times if the Previous State was as ACTION state by deferring the awaited execution results rather than handling them in an async tap

📦 Published PR as canary version: 0.12.1--canary.691.24791

Try this version out locally by upgrading relevant packages to 0.12.1--canary.691.24791

@KetanReddy KetanReddy self-assigned this Jul 23, 2025
@KetanReddy KetanReddy added the patch Increment the patch version when merged label Jul 23, 2025
@KetanReddy
Copy link
Copy Markdown
Member Author

/canary

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (91bdaef) to head (9dd104a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/player/src/player.ts 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files         333      333              
  Lines       21012    21018       +6     
  Branches     2101     2104       +3     
==========================================
+ Hits        18922    18927       +5     
- Misses       2072     2073       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KetanReddy
Copy link
Copy Markdown
Member Author

/canary

@KetanReddy KetanReddy marked this pull request as ready for review July 24, 2025 20:13
@KetanReddy KetanReddy requested a review from a team as a code owner July 24, 2025 20:13
@KetanReddy KetanReddy enabled auto-merge (squash) July 24, 2025 20:34
@KetanReddy KetanReddy merged commit 3765f42 into main Jul 24, 2025
10 checks passed
@KetanReddy KetanReddy deleted the bugfix/async-multifire branch July 24, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants