track inProgressNodes to prevent duplicate async processes#693
Merged
Conversation
…ering multiple times
557021e to
51cc75a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 90.11% 90.12%
=======================================
Files 333 333
Lines 21122 21131 +9
Branches 2107 2109 +2
=======================================
+ Hits 19035 19045 +10
+ Misses 2069 2068 -1
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KetanReddy
reviewed
Jul 29, 2025
Comment on lines
+285
to
+286
| nodeResolveCache: new Map(), | ||
| inProgressNodes: new Set(), |
Member
There was a problem hiding this comment.
Should we reset these when the view transitions just to avoid any potential issues with stale data from a previous view?
Contributor
Author
There was a problem hiding this comment.
Yeah, that was the intention here with setting up the context object. Because this is a ViewPlugin the apply gets called on each new ViewInstance so each cache should be scoped to the current view and be reinitialized on the next view state.
KetanReddy
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
onAsyncNodecould be generated multiple times if a view update caused the same async node to get resolved again before the promise completed.