Skip to content

update reference assets to support chat-ui demo from core plugin#702

Merged
spentacular merged 4 commits intomainfrom
fix-chatui-demo
Aug 8, 2025
Merged

update reference assets to support chat-ui demo from core plugin#702
spentacular merged 4 commits intomainfrom
fix-chatui-demo

Conversation

@tmarmer
Copy link
Copy Markdown
Contributor

@tmarmer tmarmer commented Aug 7, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

  • Update core reference assets plugin to handle chat-ui mock across platforms, including setup the async node plugin at the core level

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (88e628a) to head (30b5143).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   90.12%   90.31%   +0.18%     
==========================================
  Files         333      336       +3     
  Lines       21131    21224      +93     
  Branches     2109     2122      +13     
==========================================
+ Hits        19045    19168     +123     
+ Misses       2068     2038      -30     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmarmer tmarmer marked this pull request as ready for review August 7, 2025 18:01
@tmarmer tmarmer requested review from a team as code owners August 7, 2025 18:01
Copy link
Copy Markdown
Member

@KVSRoyal KVSRoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an iOS perspective, lgtm 👍🏽 .

Copy link
Copy Markdown
Member

@spentacular spentacular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spentacular spentacular merged commit 2a00068 into main Aug 8, 2025
12 checks passed
@spentacular spentacular deleted the fix-chatui-demo branch August 8, 2025 17:37
nancywu1 pushed a commit that referenced this pull request Aug 13, 2025
* update reference assets to support chat-ui demo from core plugin

* add async node plugin setup to core reference assets plugin

* add tests for ChatUiDemoPlugin

* update reference assets test to test with all plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants