Skip to content

add asyncNodePosition to createAsyncTransform options#714

Merged
tmarmer merged 5 commits intomainfrom
asycn-transform-direction
Sep 4, 2025
Merged

add asyncNodePosition to createAsyncTransform options#714
tmarmer merged 5 commits intomainfrom
asycn-transform-direction

Conversation

@tmarmer
Copy link
Copy Markdown
Contributor

@tmarmer tmarmer commented Aug 29, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

  • Added asyncNodePosition as an option to createAsyncTransform. This lets user choose if the generated async node goes to the top or bottom of the generated multi-node.

@tmarmer tmarmer requested a review from a team as a code owner August 29, 2025 17:52
@tmarmer tmarmer added the patch Increment the patch version when merged label Aug 29, 2025
Comment thread plugins/async-node/core/src/createAsyncTransform.ts Outdated
@tmarmer tmarmer force-pushed the asycn-transform-direction branch from 63a229c to 9d4d80b Compare September 2, 2025 16:42
Comment thread plugins/async-node/core/src/createAsyncTransform.ts Outdated
KetanReddy
KetanReddy previously approved these changes Sep 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.87%. Comparing base (0151c92) to head (9c551b1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   86.87%   86.87%   -0.01%     
==========================================
  Files         503      503              
  Lines       25660    25665       +5     
  Branches     2630     2632       +2     
==========================================
+ Hits        22292    22296       +4     
- Misses       3045     3046       +1     
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmarmer tmarmer merged commit 6f05a45 into main Sep 4, 2025
12 checks passed
@tmarmer tmarmer deleted the asycn-transform-direction branch September 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants