Skip to content

Adding docs-preview workflow, Canary release PR comments#720

Merged
kharrop merged 100 commits intomainfrom
docs-preview
Oct 28, 2025
Merged

Adding docs-preview workflow, Canary release PR comments#720
kharrop merged 100 commits intomainfrom
docs-preview

Conversation

@kharrop
Copy link
Copy Markdown
Member

@kharrop kharrop commented Sep 12, 2025

/canary

---
config:
  look: classic
  layout: dagre
---
flowchart LR
    n1["setup"] --> n2["bazelrc"]
    n2 --> n3["build-trunk"] & n10["build-ios-trunk"]
    n3 --> n4["test-trunk"] & n8["js-benchmark-tests-trunk"] & n9["android-test-trunk"] & n10 & n6["maybe release"] & n11["coverage-trunk"]
    n4 --> n5["build + preview docs"]
    n10 --> n6 & n11
    n9 --> n6
    n1@{ shape: rect}
Loading

/release

---
config:
  look: classic
  layout: dagre
---
flowchart LR
    n12["setup"] --> n13["bazelrc"]
    n13 --> n14["build"]
    n14 --> n15["build_ios"] & n17["android_test"] & n16["coverage"]
    n15 --> n16 & n18["release (+ docs)"]
    n17 --> n18
    n16 --> n18
    n19["build_docs"] --> n18
    n16 --> n19
    n12@{ shape: rect}
    n13@{ shape: rect}
    n14@{ shape: rect}
Loading

Comment examples:

  • PR Comment triggered by /docs:
image
  • PR Comment triggered by /canary (replaces previous docs comment if present):
image

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

This PR contains a few docs-related quality of life improvements, details below:

  • Adds a pr-comment workflow that supports command-triggered PR comments - including: /canary, /docs
  • Adds a docs preview workflow that is triggered when a collaborator adds a comment including /docs, similar to our /canary workflow. This workflow will push static docs files to https://github.com/player-ui/player-ui.github.io and publish a URL that includes PR docs changes.
  • Adds a pr-closed workflow that will run when a PR is either closed manually or merged, which will automatically clean up the pr folder in the https://github.com/player-ui/player-ui.github.io. This workflow can be expanded on in the future if needed.
  • Adds a PR comment that includes Canary release information after the "/canary" workflow is done and a new release becomes available, making it more clear to users which version is tied to when the command was run.
  • Updated full release job to be dependent on docs build success
  • Updated maybe_release to depend on android tests as well
📦 Published PR as canary version: 0.14.1--canary.720.28165

Try this version out locally by upgrading relevant packages to 0.14.1--canary.720.28165

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (2f41161) to head (40a7649).
⚠️ Report is 102 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         504      504           
  Lines       22669    22669           
  Branches     2639     2639           
=======================================
+ Hits        19444    19445    +1     
+ Misses       2896     2895    -1     
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated
Comment thread scripts/deploy-canary-docs.sh Outdated
@kharrop kharrop changed the title [WIP] Adding docs preview functionality [DO NOT REVIEW] Adding docs preview functionality Sep 12, 2025
@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Sep 12, 2025

/canary

@player-ui player-ui deleted a comment from intuit-svc Sep 12, 2025
@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Sep 13, 2025

/canary

@kharrop kharrop closed this Sep 13, 2025
@kharrop kharrop reopened this Sep 13, 2025
@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Sep 13, 2025

/canary

@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Sep 13, 2025

/canary

@player-ui player-ui deleted a comment from github-actions Bot Sep 14, 2025
@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Sep 14, 2025

/canary

@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28084 on Tue, 14 Oct 2025 22:31:03 GMT with this version:

0.14.1--canary.720.28084

📖 Docs (View site)

@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Oct 15, 2025

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Oct 15, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28105 on Wed, 15 Oct 2025 17:05:26 GMT with this version:

0.14.1--canary.720.28105

📖 Docs (View site)

@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Oct 15, 2025

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Oct 15, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28126 on Wed, 15 Oct 2025 18:24:54 GMT with this version:

0.14.1--canary.720.28126

📖 Docs (View site)

@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Oct 15, 2025

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Oct 15, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28145 on Wed, 15 Oct 2025 19:52:21 GMT with this version:

0.14.1--canary.720.28145

📖 Docs (View site)

@kharrop
Copy link
Copy Markdown
Member Author

kharrop commented Oct 15, 2025

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Oct 15, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28165 on Wed, 15 Oct 2025 21:05:56 GMT with this version:

0.14.1--canary.720.28165

📖 Docs (View site)

Comment thread .circleci/config.yml
- auto_shipit

build_and_deploy_docs_preview:
executor: benchmarks
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiosity question: why the benchmarks executor instead of a different executor?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses fewer resources and since this is just for docs, it doesn't need as much.

Comment thread .github/workflows/pr-closed.yml
variant: minimal
---

/\*_ Known issue: Actions in the hero section do not work when running in Preview mode _/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "hero" section?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KVSRoyal
KVSRoyal previously approved these changes Oct 16, 2025
@sugarmanz
Copy link
Copy Markdown
Member

Will close #52

@kharrop kharrop merged commit 7fe3976 into main Oct 28, 2025
13 checks passed
@KetanReddy KetanReddy deleted the docs-preview branch November 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants