Skip to content

export soloader from hermes#733

Merged
sugarmanz merged 1 commit intomainfrom
hermes-export-soloader
Oct 23, 2025
Merged

export soloader from hermes#733
sugarmanz merged 1 commit intomainfrom
hermes-export-soloader

Conversation

@sugarmanz
Copy link
Copy Markdown
Member

@sugarmanz sugarmanz commented Oct 23, 2025

Because SoLoader configuration is required for Hermes, we should export it from our artifact to make it easier to consume.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

Export com.facebook.soloader:soloader from hermes artifacts

📦 Published PR as canary version: 0.14.1--canary.733.28263

Try this version out locally by upgrading relevant packages to 0.14.1--canary.733.28263

@sugarmanz sugarmanz requested a review from a team as a code owner October 23, 2025 17:07
@sugarmanz sugarmanz added the patch Increment the patch version when merged label Oct 23, 2025
@sugarmanz
Copy link
Copy Markdown
Member Author

/canary

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (deb0a09) to head (07f3e84).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   86.68%   85.77%   -0.92%     
==========================================
  Files         504      504              
  Lines       25699    22669    -3030     
  Branches     2640     2639       -1     
==========================================
- Hits        22278    19444    -2834     
+ Misses       3092     2896     -196     
  Partials      329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sugarmanz sugarmanz enabled auto-merge (squash) October 23, 2025 18:59
@sugarmanz sugarmanz disabled auto-merge October 23, 2025 18:59
@sugarmanz sugarmanz merged commit 0f7ec7f into main Oct 23, 2025
11 of 12 checks passed
@KetanReddy KetanReddy deleted the hermes-export-soloader branch November 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants