Skip to content

Lowercase URLs for docs preview#741

Merged
KVSRoyal merged 1 commit intomainfrom
issue-740
Oct 30, 2025
Merged

Lowercase URLs for docs preview#741
KVSRoyal merged 1 commit intomainfrom
issue-740

Conversation

@KVSRoyal
Copy link
Copy Markdown
Member

@KVSRoyal KVSRoyal commented Oct 30, 2025

Resolves #740.

Links belonging to folders with upper case letters throw a 404 in the Docs Preview. The links apparently need to be lower case to work. Update the URL generation script to lower case the links.

Also, change the iOS folder name to ios to be consistent with the other folder names and avoid this issue in the first place.

Instances of this issue.

  1. Add docs for consuming Swift package #739 (comment). The plugins/iOS links aren't working, but changing the link to plugins/ios works.
  2. Test the case sensitivity theory #742. The content/Test/test link doesn't work, but content/test/test does work.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

And make the iOS folder lower case to follow standard
@KVSRoyal KVSRoyal mentioned this pull request Oct 30, 2025
7 tasks
@KVSRoyal KVSRoyal changed the title Issue 740 Lowercase URLs for docs preview Oct 30, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (e272eb1) to head (ea4cf84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         504      504           
  Lines       22669    22669           
  Branches     2639     2639           
=======================================
  Hits        19445    19445           
  Misses       2895     2895           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KVSRoyal
Copy link
Copy Markdown
Member Author

/docs

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Oct 30, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Docs Preview

A preview of your PR docs was deployed by CircleCI #28591 on Thu, 30 Oct 2025 01:12:26 GMT

📖 Docs (View site)

@KVSRoyal KVSRoyal marked this pull request as ready for review October 30, 2025 01:17
@KVSRoyal KVSRoyal requested a review from a team as a code owner October 30, 2025 01:17
@kharrop kharrop added the skip-release Preserve the current version when merged label Oct 30, 2025
@kharrop kharrop self-requested a review October 30, 2025 15:23
@KVSRoyal KVSRoyal merged commit 431e01d into main Oct 30, 2025
15 checks passed
@KetanReddy KetanReddy deleted the issue-740 branch November 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some docs preview links are broken

4 participants