Skip to content

Markdown handle empty#752

Merged
KetanReddy merged 9 commits intomainfrom
markdown-handle-empty
Nov 12, 2025
Merged

Markdown handle empty#752
KetanReddy merged 9 commits intomainfrom
markdown-handle-empty

Conversation

@KetanReddy
Copy link
Copy Markdown
Member

@KetanReddy KetanReddy commented Nov 4, 2025

Release Notes

Add option to provide a handler for when where nothing is returned from the markdown mapping.

📦 Published PR as canary version: 0.14.2--canary.752.28969

Try this version out locally by upgrading relevant packages to 0.14.2--canary.752.28969

@KetanReddy
Copy link
Copy Markdown
Member Author

/canary

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.78%. Comparing base (a53e774) to head (5cbb8b0).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
plugins/markdown/core/src/utils/markdownParser.ts 46.15% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   85.77%   85.78%   +0.01%     
==========================================
  Files         504      504              
  Lines       22671    22681      +10     
  Branches     2640     2650      +10     
==========================================
+ Hits        19445    19456      +11     
+ Misses       2897     2896       -1     
  Partials      329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2025

Bundle Report

Changes will increase total bundle size by 1.62kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/markdown/core 661.83kB 1.62kB (0.25%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 826 bytes 636.67kB 0.13%
cjs/index.cjs 274 bytes 9.13kB 3.09%
index.legacy-esm.js 260 bytes 8.01kB 3.35%
index.mjs 260 bytes 8.01kB 3.35%

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Nov 4, 2025
@intuit-svc
Copy link
Copy Markdown
Contributor

Build Preview

Your PR was deployed by CircleCI #28969 on Tue, 04 Nov 2025 20:38:02 GMT with this version:

0.14.2--canary.752.28969

📖 Docs (View site)

@KetanReddy KetanReddy changed the title [Internal] Markdown handle empty Markdown handle empty Nov 12, 2025
@KetanReddy KetanReddy added the minor Increment the minor version when merged label Nov 12, 2025
@KetanReddy KetanReddy marked this pull request as ready for review November 12, 2025 18:42
@KetanReddy KetanReddy requested a review from a team as a code owner November 12, 2025 18:42
@KetanReddy KetanReddy force-pushed the markdown-handle-empty branch from 3d33d55 to 5cbb8b0 Compare November 12, 2025 19:56
@KetanReddy KetanReddy merged commit 776269e into main Nov 12, 2025
14 of 15 checks passed
@KetanReddy KetanReddy deleted the markdown-handle-empty branch November 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants