Add Back in Stamping for JavaScript Builds#761
Merged
KetanReddy merged 6 commits intomainfrom Nov 21, 2025
Merged
Conversation
KetanReddy
changed the title
Member
Author
|
/canary |
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 85.78% 85.77% -0.01%
==========================================
Files 504 504
Lines 22681 22679 -2
Branches 2650 2651 +1
==========================================
- Hits 19456 19454 -2
Misses 2896 2896
Partials 329 329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 1.1kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: plugins/common-types/coreAssets Changed:
view changes for bundle: plugins/beacon/coreAssets Changed:
view changes for bundle: plugins/metrics/coreAssets Changed:
view changes for bundle: react/playerAssets Changed:
view changes for bundle: plugins/stage-revert-data/coreAssets Changed:
view changes for bundle: plugins/reference-assets/coreAssets Changed:
view changes for bundle: plugins/common-expressions/coreAssets Changed:
view changes for bundle: plugins/check-path/coreAssets Changed:
view changes for bundle: core/playerAssets Changed:
view changes for bundle: plugins/async-node/coreAssets Changed:
view changes for bundle: plugins/markdown/coreAssets Changed:
|
Member
Author
|
/canary |
intuit-svc
added a commit
to player-ui/player-ui.github.io
that referenced
this pull request
Nov 19, 2025
Contributor
Member
|
/canary |
intuit-svc
added a commit
to player-ui/player-ui.github.io
that referenced
this pull request
Nov 21, 2025
Member
|
/canary |
intuit-svc
added a commit
to player-ui/player-ui.github.io
that referenced
this pull request
Nov 21, 2025
Member
|
/canary |
intuit-svc
added a commit
to player-ui/player-ui.github.io
that referenced
this pull request
Nov 21, 2025
KetanReddy
force-pushed
the
stamp-version-and-commit
branch
from
210a554 to
0714da7
Compare
sugarmanz
approved these changes
Nov 21, 2025
| build --remote_cache_async | ||
| build --remote_download_toplevel | ||
| build --remote_timeout=3600 | ||
| build --remote_timeout=60 |
Member
Author
There was a problem hiding this comment.
Drops the time spent waiting for cache. I noticed that occasionally builds would hang when cache was taking a while to respond so this should prevent builds from stalling out of that happens.
rafbcampos
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#636 added support for properly stamping the Core and React JS bundles but had to be rolled back in #648 because the artifacts it produced were broken. After digging into the original issue it seems like it might have been because of a race condition in the source maps that were generated for the
.mjsandindex.legacy-esm.jsbuilds as only one was getting the additional substitutions (because of a non-cascading object spread) causing their map files to be slightly different. This applies the substitutions to all js builds including the IIFE for native. This PR also cleans up and marks some legacy artifacts for deprecation from when there were different versions associated with the Core and React player code bases.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
Fix stamping in core/react builds for Player version and commit used to build the bundle
📦 Published PR as canary version:
0.14.2--canary.761.29359Try this version out locally by upgrading relevant packages to 0.14.2--canary.761.29359