Error controller mobile exposure#783
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## error-controller #783 +/- ##
====================================================
+ Coverage 85.84% 85.99% +0.14%
====================================================
Files 508 512 +4
Lines 22892 23358 +466
Branches 2673 2680 +7
====================================================
+ Hits 19652 20087 +435
- Misses 2911 2932 +21
- Partials 329 339 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jvm/core/src/test/kotlin/com/intuit/playerui/core/error/ErrorControllerTest.kt
Outdated
Show resolved
Hide resolved
|
|
||
| var currentError = errorController?.getCurrentError() | ||
| assertNotNull(currentError) | ||
| assertFalse(currentError?.isUndefined() ?: true) |
There was a problem hiding this comment.
does this line not get smart casted? is the ? necessary
There was a problem hiding this comment.
if so, also applies to a few tests above
There was a problem hiding this comment.
var is not getting smart casted. updated to val. -> not really. no smart casting after assertNotNull(currentError) and still need !!
|
@brocollie08 @nancywu1 addressed comments. Could I get a re review? thanks! |
* Error controller expose to iOS/Android
3 participants
4481c71 doc update here.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?