fix ios player not detecting view change when same flow reloads #796
Merged
fix ios player not detecting view change when same flow reloads #796
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.01%
==========================================
Files 505 505
Lines 22814 22823 +9
Branches 2657 2657
==========================================
+ Hits 19579 19586 +7
- Misses 2907 2909 +2
Partials 328 328 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KVSRoyal
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
If new flow is returned from flow manager with identical flow (just different data) we hit this guard in SwiftuiPlayer
the context of the previous flow doesnt get cleared because no new view change is detected causing it to remain in End state using the stale cached player so buttons on screen dont work (transitions)
Solution:
instead of onAppear we use onChange to detect changes in loading state, this ensures unload() is called regardless of whether SwiftUI considers the view "new", which sets player = nil and allows the caching guard to pass on the next load().
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?