Skip to content

Refactor external action plugin#832

Merged
spentacular merged 2 commits intomainfrom
external-action-tweaks
Mar 30, 2026
Merged

Refactor external action plugin#832
spentacular merged 2 commits intomainfrom
external-action-tweaks

Conversation

@spentacular
Copy link
Copy Markdown
Member

@spentacular spentacular commented Mar 27, 2026

Refactor the external action plugin to remove the setTimeout. The timeout currently pushes the changes until afterTransition by default:

CleanShot 2026-03-27 at 04 10 22@2x

This is logged from this plugin + a log in the external action handler

class TestTaps implements PlayerPlugin {
  name = "custom-plugin";

  apply(player: CorePlayer) {
    player.hooks.flowController.tap(this.name, (flowController) => {
      flowController.hooks.flow.tap(this.name, (flow) => {
        flow.hooks.transition.tap(this.name, () => {
          console.log("transition");
        });

        flow.hooks.afterTransition.tap(this.name, () => {
          console.log("afterTransition");
        });
      });
    });
  }
}

This update moves the work into the afterTransition instead which ensures the changes happen more immediately rather than being pushed into the event loop further, making the updates more immediate.

Change Type (required)

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.15.2--canary.832.34348

Try this version out locally by upgrading relevant packages to 0.15.2--canary.832.34348

@spentacular
Copy link
Copy Markdown
Member Author

/canary

2 similar comments
@spentacular
Copy link
Copy Markdown
Member Author

/canary

@spentacular
Copy link
Copy Markdown
Member Author

/canary

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (fcf4954) to head (71fbf45).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #832   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spentacular spentacular marked this pull request as ready for review March 27, 2026 16:30
@spentacular spentacular requested a review from a team as a code owner March 27, 2026 16:30
intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Mar 27, 2026
Comment thread plugins/external-action/core/package.json Outdated
@intuit-svc
Copy link
Copy Markdown
Contributor

intuit-svc commented Mar 27, 2026

Build Preview

Your PR was deployed by CircleCI #34348 on Fri, 27 Mar 2026 17:58:25 GMT with this version:

0.15.2--canary.832.34348

📖 Docs (View site)

@spentacular spentacular added the patch Increment the patch version when merged label Mar 27, 2026
@spentacular
Copy link
Copy Markdown
Member Author

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Mar 27, 2026
@spentacular spentacular requested a review from adierkens March 27, 2026 18:12
intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Mar 27, 2026
@spentacular spentacular merged commit 9f3439a into main Mar 30, 2026
15 of 17 checks passed
@spentacular spentacular deleted the external-action-tweaks branch March 30, 2026 15:27
shahabdsh added a commit to shahabdsh/player that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants