Skip to content

Fix Circular Dependencies#840

Merged
KetanReddy merged 1 commit into
player-1-dot-zerofrom
feature/resolve-circular-dependencies
Apr 8, 2026
Merged

Fix Circular Dependencies#840
KetanReddy merged 1 commit into
player-1-dot-zerofrom
feature/resolve-circular-dependencies

Conversation

@KetanReddy
Copy link
Copy Markdown
Member

Closes #360

Fixes this in a much less intensive way that originally proposed by just forcing circular dependencies to resolve to the workspace version of the package. For now this is going to have to be a manual process and only works for JavaScript dependencies but solves for the current scope of the issues.

This also technically isn't a breaking change so this could go out separately not as part of the 1.0 work.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@KetanReddy KetanReddy requested a review from a team as a code owner April 7, 2026 20:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Bundle Report

Changes will increase total bundle size by 12.7kB (0.23%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/beacon/core 402.2kB 1.11kB (0.28%) ⬆️
plugins/check-path/core 420.61kB 1.11kB (0.27%) ⬆️
plugins/stage-revert-data/core 384.23kB 1.11kB (0.29%) ⬆️
plugins/reference-assets/core 463.23kB 898 bytes (0.19%) ⬆️
plugins/common-expressions/core 406.46kB 1.11kB (0.27%) ⬆️
plugins/markdown/core 661.26kB 1.09kB (0.17%) ⬆️
plugins/auto-scroll/react 19.67kB 1.22kB (6.64%) ⬆️
plugins/common-types/core 480.79kB 1.11kB (0.23%) ⬆️
plugins/metrics/core 438.77kB 1.11kB (0.25%) ⬆️
plugins/async-node/core 458.26kB 1.11kB (0.24%) ⬆️
core/partial-match-registry 28.09kB 591 bytes (2.15%) ⬆️
core/player 952.08kB 1.11kB (0.12%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/stage-revert-data/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
StageRevertDataPlugin.native.js 1.11kB 377.4kB 0.3%
view changes for bundle: plugins/auto-scroll/react

Assets Changed:

Asset Name Size Change Total Size Change (%)
cjs/index.cjs 420 bytes 7.99kB 5.55% ⚠️
index.legacy-esm.js 402 bytes 5.84kB 7.39% ⚠️
index.mjs 402 bytes 5.84kB 7.39% ⚠️
view changes for bundle: plugins/common-types/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonTypesPlugin.native.js 1.11kB 409.61kB 0.27%
view changes for bundle: plugins/reference-assets/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ReferenceAssetsPlugin.native.js 898 bytes 433.33kB 0.21%
view changes for bundle: plugins/common-expressions/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonExpressionsPlugin.native.js 1.11kB 385.21kB 0.29%
view changes for bundle: plugins/async-node/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
AsyncNodePlugin.native.js 1.11kB 410.42kB 0.27%
view changes for bundle: plugins/metrics/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MetricsPlugin.native.js 1.11kB 406.42kB 0.27%
view changes for bundle: core/partial-match-registry

Assets Changed:

Asset Name Size Change Total Size Change (%)
Registry.native.js 195 bytes 18.79kB 1.05%
cjs/index.cjs 130 bytes 4.24kB 3.16%
index.legacy-esm.js 133 bytes 2.52kB 5.56% ⚠️
index.mjs 133 bytes 2.52kB 5.56% ⚠️
view changes for bundle: plugins/beacon/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
BeaconPlugin.native.js 1.11kB 387.74kB 0.29%
view changes for bundle: core/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
Player.native.js 1.11kB 402.0kB 0.28%
view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 1.09kB 636.11kB 0.17%
view changes for bundle: plugins/check-path/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CheckPathPlugin.native.js 1.11kB 391.12kB 0.29%

@KetanReddy KetanReddy merged commit e50e1bc into player-1-dot-zero Apr 8, 2026
14 of 15 checks passed
@KetanReddy KetanReddy deleted the feature/resolve-circular-dependencies branch April 8, 2026 20:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (player-1-dot-zero@2fd16fd). Learn more about missing BASE report.
⚠️ Report is 42 commits behind head on player-1-dot-zero.

Additional details and impacted files
@@                Coverage Diff                 @@
##             player-1-dot-zero   #840   +/-   ##
==================================================
  Coverage                     ?      0           
==================================================
  Files                        ?      0           
  Lines                        ?      0           
  Branches                     ?      0           
==================================================
  Hits                         ?      0           
  Misses                       ?      0           
  Partials                     ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants