Fix the memory leak for large payloads#841
Merged
JunDangIntuit merged 7 commits intomainfrom Apr 9, 2026
Merged
Conversation
Serialize once and reuse — the previous approach called jsonDisplayString (which pretty-prints the entire tree) before jsonData(), doubling peak memory for large payloads.
Contributor
Author
|
@claude please help to review this pr. thanks. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Updated tests
Contributor
Author
|
@brocollie08 @sugarmanz May you help to take a look that android-trunk-test always failed for me (have rerun 3 times). I did not make any change in android. thanks. |
import PlayerUILogger
Serialize once and reuse — the previous approach called jsonDisplayString (which pretty-prints the entire tree) before jsonData(), doubling peak memory for large payloads.
Updated tests
import PlayerUILogger
…r-malformedData-issue' of github.com:player-ui/player into feature/Fix-the-out-of-memory-and-PlayerUI.DecodingError-malformedData-issue
JunDangIntuit
deleted the
feature/Fix-the-out-of-memory-and-PlayerUI.DecodingError-malformedData-issue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refer to: https://jira.cloud.intuit.com/browse/PLAYA-10213
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?