Skip to content

Restore Xcode local development#847

Merged
KVSRoyal merged 5 commits intomainfrom
fix-xcode
Apr 16, 2026
Merged

Restore Xcode local development#847
KVSRoyal merged 5 commits intomainfrom
fix-xcode

Conversation

@KVSRoyal
Copy link
Copy Markdown
Member

Some upgrades from #779 break local Xcode builds (although they pass in CI/CD due to bazel weirdness). Downgrade some of our bazel deps so things work locally again. Xcode 26-26.4 should work for local development.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@KVSRoyal KVSRoyal added the skip-release Preserve the current version when merged label Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (10d3f91) to head (5f10ffd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #847   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

export class ReadOnlyDataController
implements DataModelWithParser<DataModelOptions>
{
export class ReadOnlyDataController implements DataModelWithParser<DataModelOptions> {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all lint fixes. I had to relint for some reason.

Comment thread MODULE.bazel

# Android
bazel_dep(name = "rules_android", version = "0.6.5")
archive_override(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the patch file too if we're no longer using it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Removed

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Bundle Report

Changes will increase total bundle size by 10.94kB (0.19%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/pubsub/core 45.24kB 21 bytes (0.05%) ⬆️
core/make-flow 19.33kB 36 bytes (0.19%) ⬆️
plugins/common-expressions/core 406.6kB 449 bytes (0.11%) ⬆️
plugins/check-path/core 420.45kB 153 bytes (0.04%) ⬆️
plugins/stage-revert-data/core 384.13kB 212 bytes (0.06%) ⬆️
plugins/external-action/core 19.12kB 229 bytes (1.21%) ⬆️
plugins/partial-match-fingerprint/core 9.43kB 69 bytes (0.74%) ⬆️
plugins/async-node/core 458.4kB 441 bytes (0.1%) ⬆️
plugins/markdown/core 667.68kB 6.7kB (1.01%) ⬆️
core/partial-match-registry 27.62kB 128 bytes (0.47%) ⬆️
plugins/computed-properties/core 16.58kB 62 bytes (0.38%) ⬆️
plugins/reference-assets/core 463.64kB 505 bytes (0.11%) ⬆️
plugins/beacon/core 401.82kB -75 bytes (-0.02%) ⬇️
plugins/types-provider/core 11.02kB 59 bytes (0.54%) ⬆️
plugins/metrics/core 438.29kB -178 bytes (-0.04%) ⬇️
plugins/expression/core 6.82kB 56 bytes (0.83%) ⬆️
plugins/common-types/core 481.07kB 584 bytes (0.12%) ⬆️
core/player 954.29kB 1.49kB (0.16%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/beacon/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
BeaconPlugin.native.js -75 bytes 387.36kB -0.02%
view changes for bundle: plugins/reference-assets/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ReferenceAssetsPlugin.native.js 505 bytes 433.74kB 0.12%
view changes for bundle: plugins/pubsub/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
PubSubPlugin.native.js 21 bytes 22.46kB 0.09%
view changes for bundle: plugins/stage-revert-data/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
StageRevertDataPlugin.native.js 212 bytes 377.31kB 0.06%
view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 6.7kB 642.52kB 1.05%
view changes for bundle: core/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
Player.native.js 1.49kB 403.19kB 0.37%
view changes for bundle: plugins/metrics/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MetricsPlugin.native.js -178 bytes 405.94kB -0.04%
view changes for bundle: core/partial-match-registry

Assets Changed:

Asset Name Size Change Total Size Change (%)
Registry.native.js 128 bytes 18.73kB 0.69%
view changes for bundle: core/make-flow

Assets Changed:

Asset Name Size Change Total Size Change (%)
MakeFlow.native.js 36 bytes 8.89kB 0.41%
view changes for bundle: plugins/check-path/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CheckPathPlugin.native.js 153 bytes 390.97kB 0.04%
view changes for bundle: plugins/partial-match-fingerprint/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
PartialMatchFingerprintPlugin.native.js 69 bytes 5.14kB 1.36%
view changes for bundle: plugins/types-provider/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
TypesProviderPlugin.native.js 59 bytes 6.88kB 0.86%
view changes for bundle: plugins/computed-properties/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ComputedPropertiesPlugin.native.js 62 bytes 9.41kB 0.66%
view changes for bundle: plugins/expression/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ExpressionPlugin.native.js 56 bytes 4.17kB 1.36%
view changes for bundle: plugins/async-node/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
AsyncNodePlugin.native.js 441 bytes 410.55kB 0.11%
view changes for bundle: plugins/common-types/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonTypesPlugin.native.js 584 bytes 409.89kB 0.14%
view changes for bundle: plugins/external-action/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ExternalActionPlugin.native.js 229 bytes 12.72kB 1.83%
view changes for bundle: plugins/common-expressions/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonExpressionsPlugin.native.js 449 bytes 385.36kB 0.12%

@spentacular
Copy link
Copy Markdown
Member

@claude can you review this?

@claude
Copy link
Copy Markdown

claude Bot commented Apr 16, 2026

Claude finished @spentacular's task in 53s —— View job


PR Review

  • Gather context
  • Review MODULE.bazel changes
  • Review TypeScript lint fixes
  • Review pnpm-lock.yaml changes
  • Final summary

Downgrade of Bazel/iOS deps to restore local Xcode development. CI passed with the newer versions due to Bazel caching, but local builds broke. Two commits: dep downgrades + a lint fix pass.

MODULE.bazel changes

Dep Before After
rules_player 2.2.3 2.2.1
rules_xcodeproj 3.6.0 2.12.1
rules_swift 3.4.2 2.9.0
swiftlint 0.63.2 0.59.1

The archive_override for rules_android was also removed — this is fine since it was applying a mirror patch for flaky googlesource downloads, and the standard registry version of rules_android@0.6.5 fetches from GitHub releases directly (not googlesource), making the patch unnecessary. Patch file was also deleted as requested in review. Clean.

TypeScript changes

All formatting-only — no logic changes. Linter reformatted extends/implements multi-line constructs. No issues.

pnpm-lock.yaml

~7k line diff but consistent with the Bazel dep changes. No concerns.

No significant issues found. LGTM.

@KVSRoyal KVSRoyal requested a review from sugarmanz April 16, 2026 17:05
@KVSRoyal KVSRoyal marked this pull request as ready for review April 16, 2026 17:24
@KVSRoyal KVSRoyal requested review from a team as code owners April 16, 2026 17:24
@KVSRoyal KVSRoyal merged commit 81d1f13 into main Apr 16, 2026
16 checks passed
@KVSRoyal KVSRoyal deleted the fix-xcode branch April 16, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants