Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| export class ReadOnlyDataController | ||
| implements DataModelWithParser<DataModelOptions> | ||
| { | ||
| export class ReadOnlyDataController implements DataModelWithParser<DataModelOptions> { |
There was a problem hiding this comment.
These are all lint fixes. I had to relint for some reason.
|
|
||
| # Android | ||
| bazel_dep(name = "rules_android", version = "0.6.5") | ||
| archive_override( |
There was a problem hiding this comment.
Delete the patch file too if we're no longer using it
Bundle ReportChanges will increase total bundle size by 10.94kB (0.19%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: plugins/beacon/coreAssets Changed:
view changes for bundle: plugins/reference-assets/coreAssets Changed:
view changes for bundle: plugins/pubsub/coreAssets Changed:
view changes for bundle: plugins/stage-revert-data/coreAssets Changed:
view changes for bundle: plugins/markdown/coreAssets Changed:
view changes for bundle: core/playerAssets Changed:
view changes for bundle: plugins/metrics/coreAssets Changed:
view changes for bundle: core/partial-match-registryAssets Changed:
view changes for bundle: core/make-flowAssets Changed:
view changes for bundle: plugins/check-path/coreAssets Changed:
view changes for bundle: plugins/partial-match-fingerprint/coreAssets Changed:
view changes for bundle: plugins/types-provider/coreAssets Changed:
view changes for bundle: plugins/computed-properties/coreAssets Changed:
view changes for bundle: plugins/expression/coreAssets Changed:
view changes for bundle: plugins/async-node/coreAssets Changed:
view changes for bundle: plugins/common-types/coreAssets Changed:
view changes for bundle: plugins/external-action/coreAssets Changed:
view changes for bundle: plugins/common-expressions/coreAssets Changed:
|
|
@claude can you review this? |
|
Claude finished @spentacular's task in 53s —— View job PR Review
Downgrade of Bazel/iOS deps to restore local Xcode development. CI passed with the newer versions due to Bazel caching, but local builds broke. Two commits: dep downgrades + a lint fix pass. MODULE.bazel changes
The TypeScript changesAll formatting-only — no logic changes. Linter reformatted pnpm-lock.yaml~7k line diff but consistent with the Bazel dep changes. No concerns. No significant issues found. LGTM. |
Some upgrades from #779 break local Xcode builds (although they pass in CI/CD due to bazel weirdness). Downgrade some of our bazel deps so things work locally again. Xcode 26-26.4 should work for local development.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?