Refactor stateType from String to NavigationFlowStateType enum#850
Merged
JunDangIntuit merged 4 commits intomainfrom Apr 22, 2026
Merged
Conversation
… enum - Add `NavigationFlowStateType` enum in its own file (`NavigationFlowStateType.swift`), matching the JVM project structure (`NavigationFlowStateType.kt`). - Use an `unknown(String)` case with associated value for forward-compatibility: unrecognized state types from JS are preserved rather than discarded, with an assertionFailure in debug builds to catch contract mismatches early. - added unit tests
KVSRoyal
previously approved these changes
Apr 22, 2026
KVSRoyal
reviewed
Apr 22, 2026
| @@ -0,0 +1,53 @@ | |||
| import Foundation | |||
Member
There was a problem hiding this comment.
Changes look good. Seems like some of the tests are failing CI/CD though?
Contributor
Author
There was a problem hiding this comment.
The tests passed, may you review again, thanks
… enum - Add `NavigationFlowStateType` enum in its own file (`NavigationFlowStateType.swift`), matching the JVM project structure (`NavigationFlowStateType.kt`). - Use an `unknown(String)` case with associated value for forward-compatibility: unrecognized state types from JS are preserved rather than discarded, with an assertionFailure in debug builds to catch contract mismatches early. - added unit tests
…nBaseState' of github.com:player-ui/player into Refactor-stateType-from-String-to-enum-in-iOS-NavigationBaseState
JunDangIntuit
changed the title
KVSRoyal
approved these changes
Apr 22, 2026
JunDangIntuit
deleted the
Refactor-stateType-from-String-to-enum-in-iOS-NavigationBaseState
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NavigationFlowStateTypeenum in its own file (NavigationFlowStateType.swift), matching the JVM project structure (NavigationFlowStateType.kt).unknown(String)case with associated value for forward-compatibility: unrecognized state types from JS are preserved rather than discarded, with an assertionFailure in debug builds to catch contract mismatches early.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?