Prefer primitive names in union errors#236
Merged
KetanReddy merged 3 commits intoplayer-ui:mainfrom Feb 9, 2026
Merged
Conversation
shahabdsh
force-pushed
the
fix/primitive-type-expected-types
branch
from
08f1d97 to
2c02019
Compare
KetanReddy
reviewed
Feb 9, 2026
xlr/sdk/src/__tests__/sdk.test.ts
Outdated
| sdk.loadDefinitionsFromModule(ReferenceAssetsWebPluginManifest); | ||
|
|
||
| const validator = new XLRValidator(sdk.getType); | ||
| const validator = new XLRValidator(sdk.getType.bind(sdk)); |
Contributor
Author
There was a problem hiding this comment.
Just checked again and it wasn't necessary - removed it!
Use primitive node.type values when formatting expected types for union validation errors and add a regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
shahabdsh
force-pushed
the
fix/primitive-type-expected-types
branch
from
0cc3325 to
11db9b9
Compare
KetanReddy
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change will result in clearer errors for primitive value validations:
Before:
Asset Validation Error - value: Does not match any of the types: MyAsset.value | ExpressionRef | BindingRefAfter:
Asset Validation Error - value: Does not match any of the types: number | ExpressionRef | BindingRefChange Type (required)
Indicate the type of change your pull request is:
patchminormajor