Don't require secrets, otherwise we can't use secrets: inherit#24
Merged
Don't require secrets, otherwise we can't use secrets: inherit#24
secrets: inherit#24Conversation
ihostage
approved these changes
May 6, 2022
Member
ihostage
left a comment
ihostage
left a comment
There was a problem hiding this comment.
LGTM.
Very cool feature for us. Now we will can to remove a copy&pasted secrets in all repo 🎉
Member
Author
Exactly. |
ihostage
reviewed
May 6, 2022
| type: string | ||
| required: false | ||
| default: 8 | ||
| secrets: |
Member
There was a problem hiding this comment.
Just need to remove these secrets from README 😉
Member
Author
There was a problem hiding this comment.
Ah yes. The documentation... 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
secrets: inheritwe can't make the secrets required in the reusable workflow, otherwise we get an error like this one:Tested here: https://github.com/playframework/twirl/runs/6329238847?check_suite_focus=true