Remove deprecated Symbol literal

[mkurz]

Only effects the Play 2.7 folders: core-play27, play27-bootstrap3, play27-bootstrap4 (because of Scala 2.13 support)

I did not do this manually. The first four commits were done via regex, effecting the *.scala.html files only:

find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^> ]\+\) ->/Symbol(\"\1\") ->/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/get('\([^) ]\+\))/get(Symbol(\"\1\"))/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^) ]\+\))/Symbol(\"\1\"))/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^, ]\+\),/Symbol(\"\1\"),/g"

The fifth commit was done via sbt-scalafix and Scalafix Rewrites - to fix all the *.scala files. I temporarly added it to project/plugins.sbt / build.sbt, see this commit (in my own branch). I had to clone https://github.com/scala/scala-rewrites before and publishLocal it. Then I could run it via:

cd core-play27/
sbt clean "scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
sbt clean "test:scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
cd ../play27-bootstrap3/module/
sbt clean "scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
sbt clean "test:scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
cd ../sample/
sbt clean "scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
sbt clean "test:scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
cd ../../play27-bootstrap4/module/
sbt clean "scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
sbt clean "test:scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
cd ../sample/
sbt clean "scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
sbt clean "test:scalafix dependency:fix.scala213.Core@org.scala-lang:scala-rewrites:0.1.0-SNAPSHOT"
cd ../../

See

• Feature Request: build in scala.Symbol literal replace rule scalacenter/scalafix#977
• https://github.com/scala/scala-rewrites/blob/2e40d60acdd5ef37e6368ff1830d4df1bd1d948d/rewrites/src/main/scala/impl/Substitutions.scala#L125-L127

[mkurz]

@adrianhurt I know you mentioned you want to replace symbol with a simple string. However that would break all templates that take symbol parameters... I am working towards being able to deprecate twirl template arguments: playframework/twirl#273
This would make transition smoother. I hope I can finish it until Play 2.9.

[mkurz]

Ping @adrianhurt