Skip to content
This repository was archived by the owner on Apr 23, 2019. It is now read-only.

Upgrade branch 2.6.x using TemplateControl#20

Closed
gmethvin wants to merge 1 commit intoplayframework:2.6.xfrom
gmethvin:templatecontrol-2.6.x
Closed

Upgrade branch 2.6.x using TemplateControl#20
gmethvin wants to merge 1 commit intoplayframework:2.6.xfrom
gmethvin:templatecontrol-2.6.x

Conversation

@gmethvin
Copy link
Member

@gmethvin gmethvin commented Jun 3, 2017

Updated with template-control on 2017-06-03T15:58:23.726Z
  **/plugins.sbt:
    addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.0-RC1")

  **/plugins.sbt:
    addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.0-RC2")
@gmethvin gmethvin force-pushed the templatecontrol-2.6.x branch from fd630b9 to 9d8082d Compare June 3, 2017 16:01
@marcospereira
Copy link
Member

This needs to be update manually too:

[error] /home/travis/build/playframework/play-java-dagger2-example/app/dagger/MyComponentsFromContext.java:28: dagger.MyComponentsFromContext is not abstract and does not override abstract method executionContext() in play.libs.ws.ahc.AhcWSComponents
[error] public class MyComponentsFromContext extends BuiltInComponentsFromContext
[error] /home/travis/build/playframework/play-java-dagger2-example/app/dagger/MyComponentsFromContext.java:39: method does not override or implement a method from a supertype
[error]     @Override
[error] /home/travis/build/playframework/play-java-dagger2-example/app/dagger/MyComponentsFromContext.java:42: cannot find symbol
[error]   symbol: method injector()
[error]         Injector injector = super.injector();
[error] /home/travis/build/playframework/play-java-dagger2-example/app/dagger/MyComponentsFromContext.java:48: invalid method reference
[error]   cannot find symbol
[error]     symbol:   method defaultParser()
[error]     location: class dagger.MyComponentsFromContext
[error]         extraMappings.put(play.mvc.BodyParser.Default.class, this::defaultParser);

I'm closing this PR and will submit another one later.

@gmethvin gmethvin deleted the templatecontrol-2.6.x branch June 23, 2017 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants