Skip to content
This repository was archived by the owner on Apr 23, 2019. It is now read-only.

Update Dagger version and usage to reduce overhead.#23

Merged
wsargent merged 1 commit intoplayframework:2.6.xfrom
JakeWharton:jw/2017-06-23/idiomatic-dagger
Jun 23, 2017
Merged

Update Dagger version and usage to reduce overhead.#23
wsargent merged 1 commit intoplayframework:2.6.xfrom
JakeWharton:jw/2017-06-23/idiomatic-dagger

Conversation

@JakeWharton
Copy link
Contributor

  • Abstract modules do not require Dagger to create instance.
  • Stateless providers can be made static.
  • Using @BindsInstance places an instance into the graph without requiring a module instance.
  • Remove scoping from bindings which don't need it.

* Abstract modules do not require Dagger to create instance.
* Stateless providers can be made static.
* Using `@BindsInstance` places an instance into the graph without requiring a module instance.
* Remove scoping from bindings which don't need it.
@wsargent
Copy link
Member

Thanks!

@wsargent wsargent merged commit 9759a04 into playframework:2.6.x Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants