Skip to content

[3.0.x] Remove deprecated contentSecurityPolicy config + deprecated hibernate.dialect config #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkurz merged 2 commits into from
Jan 23, 2024
Merged

[3.0.x] Remove deprecated contentSecurityPolicy config + deprecated hibernate.dialect config #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c052498
Remove deprecated contentSecurityPolicy config
mkurz Jan 23, 2024
0e3e347
Setting hibernate.dialect is deprecated
mkurz Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions play-java-chatroom-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ pekko {
logging-filter = "org.apache.pekko.event.slf4j.Slf4jLoggingFilter"
}

// https://www.playframework.com/documentation/latest/SecurityHeaders
// Disable the out of the box content security policy in SecurityHeadersFilter
play.filters.headers.contentSecurityPolicy = null
Copy link
Copy Markdown
Member Author

@mkurz mkurz Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is the default anyway now.


// https://www.playframework.com/documentation/latest/AllowedHostsFilter
play.filters.hosts.allowed = ["localhost:9000", "localhost:19001"]

Expand Down
1 change: 0 additions & 1 deletion play-java-jpa-example/conf/META-INF/persistence.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<provider>org.hibernate.jpa.HibernatePersistenceProvider</provider>
<non-jta-data-source>DefaultDS</non-jta-data-source>
<properties>
<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
Copy link
Copy Markdown
Member Author

@mkurz mkurz Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed according a warning in the logs.

<property name="hibernate.hbm2ddl.auto" value="update"/>
</properties>
</persistence-unit>
Expand Down
1 change: 0 additions & 1 deletion play-java-rest-api-example/conf/META-INF/persistence.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<provider>org.hibernate.jpa.HibernatePersistenceProvider</provider>
<non-jta-data-source>DefaultDS</non-jta-data-source>
<properties>
<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
<property name="hibernate.hbm2ddl.auto" value="update"/>
</properties>
</persistence-unit>
Expand Down
3 changes: 0 additions & 3 deletions play-java-starter-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@ play.filters {

# The X-Permitted-Cross-Domain-Policies header. If null, the header is not set.
#permittedCrossDomainPolicies = "master-only"

# The Content-Security-Policy header. If null, the header is not set.
#contentSecurityPolicy = "default-src 'self'"
}

## Allowed hosts filter configuration
Expand Down
4 changes: 0 additions & 4 deletions play-scala-chatroom-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ pekko {
logging-filter = "org.apache.pekko.event.slf4j.Slf4jLoggingFilter"
}

// https://www.playframework.com/documentation/latest/SecurityHeaders
// Disable the out of the box content security policy in SecurityHeadersFilter
play.filters.headers.contentSecurityPolicy = null

// https://www.playframework.com/documentation/latest/AllowedHostsFilter
play.filters.hosts.allowed = ["localhost:9000", "localhost:19001"]

Expand Down
3 changes: 0 additions & 3 deletions play-scala-log4j2-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,6 @@ play.filters {

# The X-Permitted-Cross-Domain-Policies header. If null, the header is not set.
#permittedCrossDomainPolicies = "master-only"

# The Content-Security-Policy header. If null, the header is not set.
#contentSecurityPolicy = "default-src 'self'"
}

## Allowed hosts filter configuration
Expand Down
3 changes: 0 additions & 3 deletions play-scala-starter-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@ play.filters {

# The X-Permitted-Cross-Domain-Policies header. If null, the header is not set.
#permittedCrossDomainPolicies = "master-only"

# The Content-Security-Policy header. If null, the header is not set.
#contentSecurityPolicy = "default-src 'self'"
}

## Allowed hosts filter configuration
Expand Down
1 change: 0 additions & 1 deletion play-scala-streaming-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# Allow URLs from the same origin to be loaded by frames and scripts
play.filters.headers {
frameOptions = "SAMEORIGIN"
contentSecurityPolicy = "connect-src 'self'"
Copy link
Copy Markdown
Member Author

@mkurz mkurz Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set in line 13 anyway.

}

play.filters.enabled += play.filters.csp.CSPFilter
Expand Down
8 changes: 4 additions & 4 deletions play-scala-websocket-example/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ pekko {
}
}

play.filters.enabled += play.filters.csp.CSPFilter

# https://www.playframework.com/documentation/latest/SecurityHeaders
# Connect to localhost:9000 for content security policy on websockets
play.filters.headers {
contentSecurityPolicy = "connect-src 'self' ws://localhost:9000"
play.filters.csp.directives {
connect-src = "'self' ws://localhost:9000"
default-src = "'self'"
}

# https://www.playframework.com/documentation/latest/AllowedHostsFilter
Expand Down