Skip to content

Conversation

@ennru
Copy link
Contributor

@ennru ennru commented Jun 8, 2020

Simplify the use of Mima, get the previous version from Dynver.

Make Travis release to Bintray on merge to master.

@ennru ennru changed the title Build: Mima, Dynver and publish settings Build: Mima, Dynver and publish settings; release to Bintray from Travis Jun 8, 2020
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,8 @@
pullRequests.frequency = "@monthly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼


### Check Maven Central

- The artifacts will become visible at https://repo1.maven.org/maven2/com/typesafe/play/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah!

// Standalone implementation using AsyncHttpClient
lazy val `play-ahc-ws-standalone` = project
.in(file("play-ahc-ws-standalone"))
.enablePlugins(Publish)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how things are explicitly (instead of automagically applied).

addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.3.4")

addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.7.0")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tears of joy...

@mergify mergify bot merged commit 5fd8e47 into playframework:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants