-
Notifications
You must be signed in to change notification settings - Fork 90
Build: Mima, Dynver and publish settings; release to Bintray from Travis #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ignasi35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -0,0 +1,8 @@ | |||
| pullRequests.frequency = "@monthly" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
|
|
||
| ### Check Maven Central | ||
|
|
||
| - The artifacts will become visible at https://repo1.maven.org/maven2/com/typesafe/play/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah!
| // Standalone implementation using AsyncHttpClient | ||
| lazy val `play-ahc-ws-standalone` = project | ||
| .in(file("play-ahc-ws-standalone")) | ||
| .enablePlugins(Publish) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how things are explicitly (instead of automagically applied).
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.3.4") | ||
|
|
||
| addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.7.0") | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tears of joy...
Simplify the use of Mima, get the previous version from Dynver.
Make Travis release to Bintray on merge to master.