[#2124] fix(python): add missing unitest lib#1178
Merged
Conversation
asolntsev
reviewed
Aug 23, 2017
Contributor
asolntsev
left a comment
There was a problem hiding this comment.
@xael-fry Do I correctly understand that you want to add some 3rd-party Python testing framework to Play?
Is it really a good idea?
- Can't we just "import" this library (like we add dependencies in Java projects)?
- Who will be responsible for keeping this library up-to-date?
Member
Author
|
It is not a 3rd-party lib, it is an optional module of python 2.7 present in installer. |
Contributor
|
@xael-fry I still don't understand :) |
Member
Author
|
The lib was present before, but I accidentally remove it wen updating python. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lighthouse #2124