Scrub the code base of all cookie banner and lightbend/akka google analytics tracking#612
Conversation
ennru
left a comment
There was a problem hiding this comment.
Thank you.
Good thing to finally remove our company's tracking from the OSS project.
LGTM.
|
Thanks! |
|
@mkurz thanks for merging. Once it's deployed could you ping me here as I need to deactivate some items on my end for the cookie banner. |
|
@mkurz any news on when this might get deployed to the website? Thanks |
That's part of Google Analytics as well, I removed it, see #619.
It's live now: https://www.playframework.com/
Why not, I will finally answer Enno's email ;) |
@ennru
This removes the Lightbend/Akka managed cookie compliance banner from the Play Framework website.
Specifically this removes:
It also removes any Lightbend Google Analytics or Google Tag Manager code as we no longer can capture this data due to cookie banner removal.
Specifically this removes:
UA-37989507-1Google AnalyticsGTM-W9TKHC7Additionally this removes an old Munchkin.js include which is an old Lightbend Marketo code embed.
Please note,
autotrack.jsremains in the code base and now turns on by default as the cookie banner has been removed. Not sure whatautotrack.jsis as it's not related to Lightbend tracking as far as I can tell.Happy to transfer our Google Analytics property to PlayFramework if they would like it. It has historical data.