Skip to content

Scrub the code base of all cookie banner and lightbend/akka google analytics tracking#612

Merged
mkurz merged 1 commit intoplayframework:mainfrom
rasummer:remove-cookie-banner-and-listing
Mar 18, 2025
Merged

Scrub the code base of all cookie banner and lightbend/akka google analytics tracking#612
mkurz merged 1 commit intoplayframework:mainfrom
rasummer:remove-cookie-banner-and-listing

Conversation

@rasummer
Copy link
Copy Markdown
Contributor

@ennru

This removes the Lightbend/Akka managed cookie compliance banner from the Play Framework website.

Specifically this removes:

  • OneTrust Cookie banner includes
  • OneTrust CSS styling (inc #optanon styles)
  • Cookie policy listing page and styles

It also removes any Lightbend Google Analytics or Google Tag Manager code as we no longer can capture this data due to cookie banner removal.

Specifically this removes:

  • Removes Lightbend managed tracking related to UA-37989507-1 Google Analytics
  • Removes Lightbend managed Google Tag Manager - GTM-W9TKHC7

Additionally this removes an old Munchkin.js include which is an old Lightbend Marketo code embed.

Please note, autotrack.js remains in the code base and now turns on by default as the cookie banner has been removed. Not sure what autotrack.js is as it's not related to Lightbend tracking as far as I can tell.

Happy to transfer our Google Analytics property to PlayFramework if they would like it. It has historical data.

Copy link
Copy Markdown
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Good thing to finally remove our company's tracking from the OSS project.

LGTM.

@mkurz
Copy link
Copy Markdown
Member

mkurz commented Mar 18, 2025

Thanks!

@mkurz mkurz merged commit 627c911 into playframework:main Mar 18, 2025
@rasummer
Copy link
Copy Markdown
Contributor Author

@mkurz thanks for merging. Once it's deployed could you ping me here as I need to deactivate some items on my end for the cookie banner.

@rasummer
Copy link
Copy Markdown
Contributor Author

@mkurz any news on when this might get deployed to the website? Thanks

@mkurz mkurz mentioned this pull request Apr 22, 2025
@mkurz
Copy link
Copy Markdown
Member

mkurz commented Apr 22, 2025

Please note, autotrack.js remains in the code base and now turns on by default as the cookie banner has been removed. Not sure what autotrack.js is as it's not related to Lightbend tracking as far as I can tell.

That's part of Google Analytics as well, I removed it, see #619.

@mkurz any news on when this might get deployed to the website? Thanks

It's live now: https://www.playframework.com/

Happy to transfer our Google Analytics property to PlayFramework if they would like it. It has historical data.

Why not, I will finally answer Enno's email ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants