Skip to content

Conversation

@sonukapoor
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playfulprogramming ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:39pm

@vercel
Copy link

vercel bot commented Dec 12, 2024

@sonukapoor is attempting to deploy a commit to the OceanBit Team on Vercel.

A member of the Team first needs to authorize it.

@edpratti
Copy link
Contributor

First of all, great article. Very comprehensive!

From my quick review, there's a typo in this line: ([] are fixes)

mocking classes that [are] several layer[s] down the dependency tree.

In your Setting providers chapter, you link to documentation, but the link is specifically tagging #providers as opposed to the #componentproviders. To make matters worse, in the documentation, the linkback to contentProviders is broken because it's not all lowercase.

I'll leave it at your discretion to expand it but I do think we should at least explain when to use providers vs componentProviders if the link was intentional.

@sonukapoor
Copy link
Contributor Author

sonukapoor commented Dec 27, 2024

@PrattiDev Thank you. I will address the issues in the next few days.

@sonukapoor sonukapoor closed this Dec 29, 2024
@sonukapoor
Copy link
Contributor Author

sonukapoor commented Dec 29, 2024

@PrattiDev Fixed the typos.

I have fixed the links in my article and added a note for the module providers.

@sonukapoor sonukapoor reopened this Dec 29, 2024
@crutchcorn crutchcorn added the blog post For issues/PRs primarily related to blog posts as opposed to the code of the site label Jan 4, 2025
@edpratti
Copy link
Contributor

edpratti commented Jan 5, 2025

@sonukapoor It's all good! We'll be publishing it this week. Thank you so much for the contribution!

@edpratti edpratti merged commit f25f9b8 into playfulprogramming:main Jan 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blog post For issues/PRs primarily related to blog posts as opposed to the code of the site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants