Conversation
…pplying cookies, as well as associated tests.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automatic cookie management functionality to the AsyncHttpClient library. The implementation captures Set-Cookie headers from HTTP responses and automatically includes them in subsequent requests when the domain, path, and security requirements match.
Key changes:
- Cookie storage with domain, path, and secure attribute support
- Automatic Set-Cookie header parsing and Cookie header application
- Public API methods for manual cookie management (
clearCookies,setCookie)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/AsyncHttpClient.h | Added public cookie management API and private cookie storage structures |
| src/AsyncHttpClient.cpp | Implemented cookie parsing, storage, matching logic, and automatic application to requests |
| test/test_redirects/test_main.cpp | Added tests for basic cookie roundtrip and path/secure attribute validation |
| test/compile_test_internal/compile_test.cpp | Added new basic compilation test file |
| platformio.ini | Updated build paths to reference new compile test location |
| README.md | Documented new cookie management features and API methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add cookie management, and keep alive management