Skip to content

Conversation

@playmiel
Copy link
Owner

@playmiel playmiel commented Dec 9, 2025

security and correction update

@playmiel playmiel self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 09:23
@playmiel playmiel added the enhancement New feature or request label Dec 9, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces security hardening and bug fixes for version 1.1.3, adding input validation, resource limits, and improved security controls across URL parsing, TLS fingerprint validation, and cookie handling.

Key Changes:

  • Added comprehensive URL validation with length limits, character sanitization, and strict host/port parsing
  • Implemented TLS fingerprint format validation to catch invalid configurations early
  • Enhanced cookie security with size limits, public suffix checking, and improved cross-origin header filtering

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
src/UrlParser.cpp Adds security validation functions for URLs including length limits (2048 bytes), character validation, host validation (max 255 chars), and robust port parsing with overflow protection
src/AsyncTransport.cpp Implements early validation of TLS fingerprint format, detecting invalid hex strings before connection attempts
src/AsyncHttpClient.cpp Introduces cookie jar limits (16 cookies, 4KB max), public suffix list for cookie domain validation, expanded cross-origin sensitive header filtering, and default body/header size limits
README.md Updates documentation to reflect new default limits for headers (~2.8 KiB) and body (8 KiB), adds keep-alive documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@playmiel playmiel merged commit 181392f into main Dec 16, 2025
23 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants