Skip to content

Use docker multistage build#8

Merged
playpauseandstop merged 1 commit intoplaypauseandstop:masterfrom
zhukovgreen:use-docker-multistage-build
Feb 28, 2021
Merged

Use docker multistage build#8
playpauseandstop merged 1 commit intoplaypauseandstop:masterfrom
zhukovgreen:use-docker-multistage-build

Conversation

@zhukovgreen
Copy link
Copy Markdown
Contributor

This MR introduces some refactoring of the Dockerfile such as:

  • multistage build, where the poetry is installed in a separate stage and then the binary to be copied to the development stage (without build deps)
  • versions, and dependencies are moved to the top as env vars

Using this approach allows the image to reduce from 829MB -> 675MB

Using this approach the image reduced from 829MB -> 675MB
@playpauseandstop
Copy link
Copy Markdown
Owner

Hi @zhukovgreen

Nice idea! Merging your MR as is and will work next week to update images to latest Python and dev versions

Also, will change poetry-builder-base stage to poetry-stage

@playpauseandstop playpauseandstop merged commit f288b6d into playpauseandstop:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants