Conversation
- RPC events name sync between players. - Made Players dictionary private #66
SaadBazaz
requested changes
May 9, 2024
Collaborator
SaadBazaz
left a comment
SaadBazaz
left a comment
There was a problem hiding this comment.
Either my eyes are deceiving me, or I can't see the private Players change.
SaadBazaz
requested changes
May 9, 2024
Collaborator
SaadBazaz
left a comment
SaadBazaz
left a comment
There was a problem hiding this comment.
- Add description comments
- Write dry runs on all cases in mind (no need to actually build and run)
SaadBazaz
approved these changes
May 10, 2024
Collaborator
|
I have a hunch this methodology might cause Race conditions upon high load. Needs testing on high performance calls between multiple players, with multiple RPCs. Instead of saving a state, maybe send some metadata alongside each RPC call? That way, it's guaranteed to reach along with the RPC call. |
SaadBazaz
requested changes
May 10, 2024
Collaborator
SaadBazaz
left a comment
SaadBazaz
left a comment
There was a problem hiding this comment.
What scenarios has this been tested on?
Closed
Collaborator
|
Merging in favor of a working solution instead of over engineering. Noted down problems in Refactor Umbrella issue. |
This was referenced May 11, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix, RPC part needs to be refactored, might be better to handle within JS. #40