Conversation
SaadBazaz
reviewed
May 23, 2024
SaadBazaz
reviewed
May 23, 2024
Collaborator
|
We should be pushing out a callback manager which we can use for WaitForState, solving the original problem in #75 . |
SaadBazaz
approved these changes
Jun 1, 2024
|
|
||
| private static string GenerateKey() | ||
| { | ||
| return Guid.NewGuid().ToString(); |
Collaborator
There was a problem hiding this comment.
Do you think timestamps can serve as a good enough key, or can there be collisions? Just a thought. Because that way you can keep track of the callbacks stored, according to time.
Collaborator
There was a problem hiding this comment.
Maybe give this file and folder an appropriate name too?
(instead of src/index.js)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallbackManager.cswhich will replace all of the Dictionaries/Lists we are using for handling callbacks for different parts of playroomAction(void)TODO:
Based On #75
Relates to #40