Enable ShortenAbsoluteLabelsToRelative flag#10
Closed
hartblanc wants to merge 1 commit intoplease-build:masterfrom
Closed
Enable ShortenAbsoluteLabelsToRelative flag#10hartblanc wants to merge 1 commit intoplease-build:masterfrom
hartblanc wants to merge 1 commit intoplease-build:masterfrom
Conversation
This will ensure that absolute labels to package-local targets (e.g. //a/b/c:d) are transformed into local labels (e.g. :d) by please format.
|
Rather than just enabling this globally, can we make it possible to enable this with a config flag in Please? That would probably involve introducing a concept of RewriteOpts that can be passed through the |
Author
|
Okay, yep, I can give that a go 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that absolute labels to package-local targets (e.g. //a/b/c:d) are transformed into local labels (e.g. :d) by the please format command.
The aim of this change is ultimately to address thought-machine/please#3471
I have tested the change by adding a test case to github.com/thought-machine which tests the scenario described in the issue. I will raise a a PR with this test case when bumping the version of github.com/thought-machine/please-build/buildtools used by github.com/thought-machine/please.