Closed
Conversation
This is based on work that @samwestmoreland began but became stagnant. This adds a small tool to resolve wheels from names (with optional versions) to their wheel download URLs.
The interpreter being locked to the current interpreter in the passed arguments was too restrictive. We needed to account for two things: 1. Intepreters should be a set including generic ones (such as py3) 2. The platform should always match the short phrase any With these two changes made we now verify correctly that the following command works: ``` plz run //tools/wheel_resolver -- --package pytest_unordered --version 0.6.0 ``` Includes a test case of the above to ensure no regressions.
Contributor
|
I think this doesn't quite work with the python rules as is. The previous version in v0 did the downloading as well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on work that @samwestmoreland began but became stagnant. This adds a small tool to resolve wheels from names (with optional versions) to their wheel download URLs.