Skip to content

Allow the name_scheme argument to python_wheel to be a list instead of a single string.#171

Merged
toastwaffle merged 5 commits intoplease-build:masterfrom
toastwaffle:name_scheme
Aug 21, 2024
Merged

Allow the name_scheme argument to python_wheel to be a list instead of a single string.#171
toastwaffle merged 5 commits intoplease-build:masterfrom
toastwaffle:name_scheme

Conversation

@toastwaffle
Copy link
Contributor

No description provided.

Copy link
Contributor

@goddenrich goddenrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if this is a general thing with github but I can seem to add a comment to build_def/python.build_defs line 515:522 which says


    This is a lightweight pip-free alternative to pip_library which supports cross-compiling.
    Rather than leaning on pip which is difficult to achieve reproducible builds with and
    support on different platforms, this rule is a simple wrapper around curl and unzip.
    Unless otherwise specified, the wheels are expected to adhere to common naming schemes,
    such as:
      <package_name>-<version>[-<os>-<arch>].whl
      <package_name>-<version>[-<os>_<arch>].whl
      <package_name>-<version>.whl

I think this doc needs updating now the wheel resolver can be used

@tm-jdelapuente
Copy link
Contributor

Hey, can you provide a bit of context here? I'm not following the motivation to do this change

@toastwaffle toastwaffle merged commit 2bb0d87 into please-build:master Aug 21, 2024
@toastwaffle toastwaffle deleted the name_scheme branch August 21, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants