Allow the name_scheme argument to python_wheel to be a list instead of a single string.#171
Merged
toastwaffle merged 5 commits intoplease-build:masterfrom Aug 21, 2024
Merged
Conversation
…ad of a single string.
goddenrich
approved these changes
Aug 20, 2024
Contributor
goddenrich
left a comment
There was a problem hiding this comment.
Im not sure if this is a general thing with github but I can seem to add a comment to build_def/python.build_defs line 515:522 which says
This is a lightweight pip-free alternative to pip_library which supports cross-compiling.
Rather than leaning on pip which is difficult to achieve reproducible builds with and
support on different platforms, this rule is a simple wrapper around curl and unzip.
Unless otherwise specified, the wheels are expected to adhere to common naming schemes,
such as:
<package_name>-<version>[-<os>-<arch>].whl
<package_name>-<version>[-<os>_<arch>].whl
<package_name>-<version>.whl
I think this doc needs updating now the wheel resolver can be used
Contributor
|
Hey, can you provide a bit of context here? I'm not following the motivation to do this change |
tm-jdelapuente
approved these changes
Aug 20, 2024
SpangleLabs
approved these changes
Aug 21, 2024
SpangleLabs
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.