Remove site-wide dependency on setuptools in test suite#202
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Nov 7, 2024
Merged
Conversation
One set of tests, in `//test/local`, ensures that setuptools can be imported when Python is not invoked with the `-S` option and that it can't be imported when Python is invoked with the `-S` option. This assumes that setuptools is installed site-wide (i.e., in a directory added to `sys.path` by the site module), which isn't necessarily the case. Refactor these tests to check the value of `sys.flags.no_site`, which is an explicit way to identify whether the `-S` option was passed to Python.
chrisnovakovic
force-pushed
the
rework-site-package-import-test
branch
from
eaf9726 to
4024297
Compare
peterebden
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One set of tests, in
//test/local, ensures that setuptools can be imported when Python is not invoked with the-Soption and that it can't be imported when Python is invoked with the-Soption. This assumes that setuptools is installed site-wide (i.e., in a directory added tosys.pathby the site module), which isn't necessarily the case.Refactor these tests to check the value of
sys.flags.no_site, which is an explicit way to identify whether the-Soption was passed to Python.