Implement missing locate_file method in pex meta path finder#203
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Nov 7, 2024
Merged
Conversation
This is an abstract method of `importlib.metadata.Distribution` that must be implemented in Python >= 3.12 to avoid `DeprecationWarning`s. It doesn't actually make sense for `locate_file` to return anything in a `PexDistribution`, given that the files it finds exist in a zip file rather than on a real file system.
peterebden
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an abstract method of
importlib.metadata.Distributionthat must be implemented in Python >= 3.12 to avoidDeprecationWarnings. It doesn't actually make sense forlocate_fileto return anything in aPexDistribution, given that the files it finds exist in a zip file rather than on a real file system.