Skip to content

Add remote files for the tools and set the default values #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tatskaari merged 2 commits into from
Apr 20, 2022
Merged

Add remote files for the tools and set the default values #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c8c002
Add remote files for the tools and set the default values
Apr 19, 2022
eaa5bbe
Do a release too
Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .plzconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ ImportPath = github.com/please-build/python-rules
; embedtool = //tools/please_go_embed
gotool = //third_party/go:toolchain|go

[Java]
JarCatTool = //tools:arcat

[PluginDefinition]
name = python
Expand All @@ -25,7 +23,7 @@ Inherit = true

[PluginConfig "pex_tool"]
ConfigKey = PexTool
DefaultValue = //tools/please_pex
DefaultValue = //tools:please_pex
Inherit = true

[PluginConfig "interpreter_options"]
Expand Down Expand Up @@ -90,7 +88,7 @@ Repeatable = true

[PluginConfig "wheel_tool"]
ConfigKey = WheelTool
DefaultValue = //tools/wheel_resolver
DefaultValue = //tools:wheel_resolver
Optional = true
Inherit = true

Expand Down
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 0.6.1
-------------
* Use remote file for tools #69

Version 0.6.0
-------------
* Set tool-related config to inherit from host repo #58
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.6.0
0.6.1
29 changes: 26 additions & 3 deletions tools/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,33 @@ subinclude("//build_defs:version")

version(name = "version")
Copy link
Contributor

@tiagovtristao tiagovtristao Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is no longer needed


TOOLS_VERSION = "0.1.1"

remote_file(
name = "please_pex",
url = f"https://github.com/please-build/python-rules/releases/download/tools-v{TOOLS_VERSION}/please_pex-{TOOLS_VERSION}-{CONFIG.HOSTOS}_{CONFIG.HOSTARCH}",
hashes = [
"3aa6d8b295bf99797e723bb7a5740de63351f091c64da65fd7ffa0b2c7ea5ce0", # linux_amd64
"575c065da0053e75e69d6a684b42cd07f775dd2ace9f4b5d26feb37766788587", # linux_arm64
"d1e58c872bd451eff6afe21513a99ef02e502097bf548c8d7382c2f2c900aef7", # darwin_amd64
"db72e816085c03160310c18c6a1c6442a2c2e051fba31a7f05b848b0a0efdc77", # darwin_arm64
"c31cb4ad4e60200de92fd0bf0cebba0a72f4ec0b8ffe56754c7ac2a867e10ed6", # freebsd_amd64
],
binary = True,
visibility = ["PUBLIC"],
)


remote_file(
name = "arcat",
url = f"https://github.com/please-build/arcat/releases/download/v1.0.0/arcat-1.0.0-{CONFIG.HOSTOS}_{CONFIG.HOSTARCH}",
hashes = ["6705304dde3cf358d7b8f5a034dfcc8242474b76d0e439b2f39a7a99f8612749"],
name = "wheel_resolver",
url = f"https://github.com/please-build/python-rules/releases/download/tools-v{TOOLS_VERSION}/wheel_resolver-{TOOLS_VERSION}-{CONFIG.HOSTOS}_{CONFIG.HOSTARCH}",
hashes = [
"40303befa469874270246082d914aef3f28461456a57e87caf6d0e0eb77d8629", # linux_amd64
"0c84c59d4ddf1e6904775f7f931a883f98e964f2723a159cce6b8b7dc05f60f6", # linux_arm64
"7c9244a886d06cc210c9776c0fa177730d9daebcc87db0ed885f215bf338238e", # darwin_amd64
"e76d21dc9f1e4e4afaec6a91119884c34f640229cf0518b28c2af4ef3eb8f1d1", # darwin_arm64
"1eec1f69154170702d2f42a88442309648d120ae5020b583a183d1b467767733", # freebsd_amd64
],
binary = True,
visibility = ["PUBLIC"],
)