fix(plugins): move hand-written skills from .agents/skills/ to skills/#164
fix(plugins): move hand-written skills from .agents/skills/ to skills/#164
Conversation
The hand-written use-mastra skill was added at .agents/skills/use-mastra/ in #161, but .agents/skills/ is reserved for vendor-managed skills.sh output tracked in skills-lock.json (see CLAUDE.md). Move it to the default skills/ location and switch the plugin.json skills field to array form ["./skills/", "./.agents/skills/"] so both paths load. No skill content changed. Refs #161
…ention The hand-written use-better-auth skill was added at .agents/skills/use-better-auth/ in #159, but .agents/skills/ is reserved for vendor-managed skills.sh output tracked in skills-lock.json (see CLAUDE.md). Move it to the default skills/ location and switch the plugin.json skills field to array form ["./skills/", "./.agents/skills/"] so both paths load. No skill content changed. Refs #159
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
No issues found across 13 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant CLI as Claude Code CLI
participant Json as plugin.json
participant DevDir as /skills/ (Developer)
participant VendorDir as /.agents/skills/ (Vendor)
participant Lock as skills-lock.json
Note over CLI, Lock: Plugin Initialization & Skill Loading
CLI->>Json: Read plugin manifest
Json-->>CLI: CHANGED: skills: ["./skills/", "./.agents/skills/"]
Note over CLI, DevDir: Stage 1: Load Author-Managed Skills
CLI->>DevDir: NEW: Scan directory for hand-written skills
Note right of DevDir: e.g. use-mastra, use-better-auth
DevDir-->>CLI: Return skill definitions (SKILL.md + references)
Note over CLI, VendorDir: Stage 2: Load Vendor-Managed Skills
CLI->>VendorDir: Scan directory for automated skills
opt Managed Path Validation
CLI->>Lock: Check skills-lock.json
Lock-->>CLI: Verified vendor skill list
end
VendorDir-->>CLI: Return framework-generated skill definitions
CLI->>CLI: Merge and register all discovered skills
Note over CLI: Skills from both paths available to Agent context
There was a problem hiding this comment.
Code Review
This pull request moves hand-written skills for the better-auth and mastra plugins from the .agents/skills/ directory to the skills/ directory to align with repository conventions. The plugin.json files for both plugins were updated to support multiple skill paths and the versions were incremented. Feedback was provided to include comparison links and maintain consistent date formatting in the CHANGELOG.md entries for both plugins.
… them)
Both CHANGELOG.md and plugin.json version are auto-managed by
release-please for plugins/* (see release-please-config.json
extra-files: [{ jsonpath: "$.version" }] and existing release
PRs #158/#160/#163). Manual edits race with the next release PR.
Skill relocations and the plugin.json `skills` array change remain
intact — they're the actual fix release-please will pick up via the
fix(...) commits already on this branch.
There was a problem hiding this comment.
2 issues found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="plugins/better-auth/.claude-plugin/plugin.json">
<violation number="1">
P2: The plugin manifest version was decremented to 1.2.0; this should remain/increment to 1.2.1 for a patch release.</violation>
</file>
<file name="plugins/mastra/.claude-plugin/plugin.json">
<violation number="1">
P2: The manifest version was downgraded to `1.3.0`; this should be `1.3.1` for the current release changes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary
Hand-written skills
use-mastra(#161) anduse-better-auth(#159) were committed toplugins/<name>/.agents/skills/, but per repo convention (seeCLAUDE.md), that path is reserved for vendor-managed skills.sh-installed skills tracked inskills-lock.json(read-only, do not modify directly). Hand-written skills belong in the defaultplugins/<name>/skills/location.This PR relocates both skills and updates the
skillsfield in eachplugin.jsonto the array form["./skills/", "./.agents/skills/"]so Claude Code loads from both locations (per the official plugin reference: a customskillspath replaces the default unless you opt back in via the array form).Version bumps and CHANGELOG entries are intentionally not included — release-please owns both for
plugins/*viarelease-please-config.jsonand will bump them automatically on the nextchore: release mainPR based on thefix(...)commits in this branch.Changes
plugins/mastra/git mv .agents/skills/use-mastra → skills/use-mastra(4 files, pure rename)plugin.json:"skills": "./.agents/skills/"→["./skills/", "./.agents/skills/"]plugins/better-auth/git mv .agents/skills/use-better-auth → skills/use-better-auth(5 files, pure rename)plugin.json: same array changeWhat's NOT touched
mastra/in mastra plugin; 5 best-practices dirs in better-auth) — left intact under.agents/skills/.skills-lock.jsonfiles — they only track vendor skills; hand-written skills are not registered there.SKILL.md,references/*.md) — pure relocation, byte-identical.plugin.jsonversionandCHANGELOG.md— release-please owns these.Verification
Related
use-mastra)use-better-auth)