Skip to content

chore(review): add review plugin configuration#94

Merged
amondnet merged 2 commits intomainfrom
chore/review-plugin-setup
Mar 19, 2026
Merged

chore(review): add review plugin configuration#94
amondnet merged 2 commits intomainfrom
chore/review-plugin-setup

Conversation

@amondnet
Copy link
Copy Markdown
Contributor

@amondnet amondnet commented Mar 19, 2026

Summary

  • Add .please/config.yml with review plugin settings (cubic CLI + Gemini CLI)
  • Add .gemini/settings.json for Gemini CLI context configuration (CLAUDE.md + GEMINI.md)
  • Add .please/state/ to .gitignore for runtime state files

Details

  • cubic CLI: enabled with --json -b default flags
  • Gemini CLI: enabled with --sandbox default flags, default model
  • Gemini context: configured to read CLAUDE.md and GEMINI.md as project context

Test plan

  • Verify .please/config.yml is valid YAML
  • Verify .gemini/settings.json is valid JSON
  • Verify /review:code-review reads config correctly

Summary by cubic

Standardizes automated code reviews by enabling cubic and gemini CLIs with defaults. Adds shared review context and ignores plugin runtime files.

  • Adds .please/config.yml to enable cubic (--json -b) and gemini (--sandbox) by default.
  • Adds .gemini/settings.json to load CLAUDE.md as context (removed GEMINI.md).
  • Adds .please/state/ to .gitignore; adds trailing newlines to .gitignore and .please/config.yml.

Written for commit 327f4d8. Summary will update on new commits.

Add cubic CLI and Gemini CLI review settings in .please/config.yml,
Gemini context configuration in .gemini/settings.json, and .please/state/
to .gitignore for runtime state files.
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
claude-code-plugins Ready Ready Preview, Comment Mar 19, 2026 2:55am

Request Review

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the foundational configuration for integrating code review plugins into the project workflow. It introduces a dedicated configuration file for cubic and gemini review tools, enabling their use with predefined settings. Concurrently, the .gitignore file is updated to prevent the accidental inclusion of transient state files generated by these new tools, maintaining a clean repository.

Highlights

  • Review Plugin Configuration: A new configuration file, .please/config.yml, has been added to enable and configure the cubic and gemini review plugins. This sets up default flags for both CLI tools.
  • Git Ignore Update: The .gitignore file has been updated to include .please/state/, ensuring that runtime state files generated by the review plugins are not committed to the repository.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/settings.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces configuration for the cubic and gemini review plugins and updates the .gitignore file. The changes are straightforward and logical. I have a couple of minor suggestions to align with common file formatting conventions.

Comment thread .gitignore Outdated
Comment thread .please/config.yml Outdated
@amondnet amondnet self-assigned this Mar 19, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 4/5

  • This PR is likely safe to merge with minimal risk, since the reported issue is a configuration mismatch rather than an application runtime bug.
  • The most significant issue is in .gemini/settings.json: it references GEMINI.md, so the intended Gemini context will not load until that file is added or the reference is removed.
  • Given severity 5/10 and high confidence, this is a concrete but limited-impact tooling/documentation behavior issue, not a clear user-facing regression.
  • Pay close attention to .gemini/settings.json - it points to missing GEMINI.md, which prevents expected context loading.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".gemini/settings.json">

<violation number="1" location=".gemini/settings.json:3">
P2: This config references `GEMINI.md`, but that file does not exist in the repository. The extra Gemini context will never be loaded until the file is added or removed from this list.</violation>
</file>
Architecture diagram
sequenceDiagram
    participant User as User / CI
    participant Please as please CLI
    participant Config as .please/config.yml
    participant Cubic as cubic CLI
    participant Gemini as gemini CLI
    participant FS as Local Filesystem

    Note over User,FS: Runtime Flow for /review:code-review

    User->>Please: Trigger code review
    Please->>Config: NEW: Load review plugin settings
    Config-->>Please: cubic: enabled, gemini: enabled

    rect rgb(30, 41, 59)
    Note over Please,Cubic: Plugin: cubic
    Please->>Cubic: NEW: Execute with "--json -b" flags
    Cubic->>FS: Read repository diff
    Cubic-->>Please: Analysis results
    end

    rect rgb(23, 37, 84)
    Note over Please,Gemini: Plugin: gemini
    Please->>Gemini: NEW: Execute with "--sandbox" flags
    Gemini->>FS: NEW: Load .gemini/settings.json
    Gemini->>FS: NEW: Read context (CLAUDE.md, GEMINI.md)
    Gemini-->>Please: AI-generated review feedback
    end

    Please->>FS: NEW: Persist runtime state to .please/state/
    Please-->>User: Consolidated review report
Loading

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread .gemini/settings.json Outdated
- Add trailing newline to .gitignore
- Add trailing newline to .please/config.yml
- Remove non-existent GEMINI.md reference from .gemini/settings.json
@amondnet amondnet merged commit 9931a15 into main Mar 19, 2026
7 checks passed
@amondnet amondnet deleted the chore/review-plugin-setup branch March 19, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant