chore(review): add review plugin configuration#94
Conversation
Add cubic CLI and Gemini CLI review settings in .please/config.yml, Gemini context configuration in .gemini/settings.json, and .please/state/ to .gitignore for runtime state files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational configuration for integrating code review plugins into the project workflow. It introduces a dedicated configuration file for Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces configuration for the cubic and gemini review plugins and updates the .gitignore file. The changes are straightforward and logical. I have a couple of minor suggestions to align with common file formatting conventions.
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- This PR is likely safe to merge with minimal risk, since the reported issue is a configuration mismatch rather than an application runtime bug.
- The most significant issue is in
.gemini/settings.json: it referencesGEMINI.md, so the intended Gemini context will not load until that file is added or the reference is removed. - Given severity 5/10 and high confidence, this is a concrete but limited-impact tooling/documentation behavior issue, not a clear user-facing regression.
- Pay close attention to
.gemini/settings.json- it points to missingGEMINI.md, which prevents expected context loading.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".gemini/settings.json">
<violation number="1" location=".gemini/settings.json:3">
P2: This config references `GEMINI.md`, but that file does not exist in the repository. The extra Gemini context will never be loaded until the file is added or removed from this list.</violation>
</file>
Architecture diagram
sequenceDiagram
participant User as User / CI
participant Please as please CLI
participant Config as .please/config.yml
participant Cubic as cubic CLI
participant Gemini as gemini CLI
participant FS as Local Filesystem
Note over User,FS: Runtime Flow for /review:code-review
User->>Please: Trigger code review
Please->>Config: NEW: Load review plugin settings
Config-->>Please: cubic: enabled, gemini: enabled
rect rgb(30, 41, 59)
Note over Please,Cubic: Plugin: cubic
Please->>Cubic: NEW: Execute with "--json -b" flags
Cubic->>FS: Read repository diff
Cubic-->>Please: Analysis results
end
rect rgb(23, 37, 84)
Note over Please,Gemini: Plugin: gemini
Please->>Gemini: NEW: Execute with "--sandbox" flags
Gemini->>FS: NEW: Load .gemini/settings.json
Gemini->>FS: NEW: Read context (CLAUDE.md, GEMINI.md)
Gemini-->>Please: AI-generated review feedback
end
Please->>FS: NEW: Persist runtime state to .please/state/
Please-->>User: Consolidated review report
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add trailing newline to .gitignore - Add trailing newline to .please/config.yml - Remove non-existent GEMINI.md reference from .gemini/settings.json
Summary
.please/config.ymlwith review plugin settings (cubic CLI + Gemini CLI).gemini/settings.jsonfor Gemini CLI context configuration (CLAUDE.md+GEMINI.md).please/state/to.gitignorefor runtime state filesDetails
--json -bdefault flags--sandboxdefault flags, default modelCLAUDE.mdandGEMINI.mdas project contextTest plan
.please/config.ymlis valid YAML.gemini/settings.jsonis valid JSON/review:code-reviewreads config correctlySummary by cubic
Standardizes automated code reviews by enabling
cubicandgeminiCLIs with defaults. Adds shared review context and ignores plugin runtime files..please/config.ymlto enablecubic(--json -b) andgemini(--sandbox) by default..gemini/settings.jsonto loadCLAUDE.mdas context (removedGEMINI.md)..please/state/to.gitignore; adds trailing newlines to.gitignoreand.please/config.yml.Written for commit 327f4d8. Summary will update on new commits.