Fix secret redaction formatting (#2805)#2830
Merged
plengauer merged 1 commit intoJan 28, 2026
Merged
Conversation
Co-authored-by: Philipp Lengauer <100447901+plengauer@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a formatting issue in secret redaction logic within the GitHub Actions workflow instrumentation. Specifically, it addresses how the secrets_to_redact field is updated when using the "all" redaction strategy.
Changes:
- Modified the "all" case in the secret redaction strategy switch statement to properly delete existing
secrets_to_redactentries before setting new values
moflwi
approved these changes
Jan 28, 2026
plengauer
deleted the
backport/5e38f06caf716e97e3434d0e5aa3fcd1ccc63134
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of commit 5e38f06