Skip to content

Comments

Simplify auto-approve workflow by removing condition#2946

Merged
plengauer merged 5 commits intomainfrom
plengauer-patch-1
Feb 18, 2026
Merged

Simplify auto-approve workflow by removing condition#2946
plengauer merged 5 commits intomainfrom
plengauer-patch-1

Conversation

@plengauer
Copy link
Owner

Removed conditional check for approval before posting review.

Removed conditional check for approval before posting review.
@plengauer plengauer self-assigned this Feb 17, 2026
@plengauer plengauer marked this pull request as ready for review February 17, 2026 13:12
@plengauer plengauer requested a review from moflwi as a code owner February 17, 2026 13:12
Copilot AI review requested due to automatic review settings February 17, 2026 13:12
@plengauer plengauer enabled auto-merge (squash) February 17, 2026 13:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the auto-approve workflow by removing the conditional check that previously verified the approval type before posting a review. The workflow now unconditionally posts an approval review.

Changes:

  • Removed the conditional check that validated .type = approve-pr before posting a review
  • Simplified the workflow to directly post approval reviews without type validation

@plengauer plengauer disabled auto-merge February 17, 2026 22:18
@plengauer plengauer marked this pull request as draft February 17, 2026 22:18
@plengauer plengauer marked this pull request as ready for review February 18, 2026 16:15
@plengauer plengauer enabled auto-merge (squash) February 18, 2026 16:15
@plengauer plengauer disabled auto-merge February 18, 2026 18:30
@plengauer plengauer merged commit 3fcb904 into main Feb 18, 2026
86 of 104 checks passed
@plengauer plengauer deleted the plengauer-patch-1 branch February 18, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant