Conversation
Added integration job for Super Linter in GitHub Actions workflow.
Add function to declare variables as global if conditions are met.
Removed the _otel_declare_maybe_global function from agent.sh.
plengauer
changed the title
Consolidate export statements for functions and adjust logging behavior.
Removed the otel_observe function definitions and related checks.
Add debug logging for instrumenting CodeQL action
Remove debug echo statement from codeql instrumentation script.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shell auto-instrumentation to better handle declare behavior in sourced contexts, improve GNU Parallel injection (including env assignments and functions), and adds a GitHub Actions integration job for Super Linter.
Changes:
- Add
declarealiasing + adjust special-command filtering and export reinstrumentation logic in the agent. - Update GNU Parallel argument injection to support
FOO=BAR cmdstyle and bash functions. - Add Super Linter GitHub Actions integration and a Super Linter–specific instrumentation script.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/auto/test_auto_injection_parallel.sh | Adds a new GNU Parallel test case for function execution and span assertions. |
| src/usr/share/opentelemetry_shell/agent.sh | Adjusts export reinstrumentation, adds declare aliasing, and updates special filtering. |
| src/usr/share/opentelemetry_shell/agent.instrumentation.parallel.sh | Enhances GNU Parallel injection to translate env assignments and detect executables/functions. |
| src/usr/share/opentelemetry_shell/agent.instrumentation.github.actions.superlinter.sh | Adds an instrumentation shim that patches Super Linter shell scripts in-place when running in GHA. |
| src/usr/share/opentelemetry_shell/agent.instrumentation.github.actions.codeql.sh | Narrows CodeQL injection to github/codeql-action runs. |
| .github/workflows/test_github.yml | Adds a new integration job to run Super Linter under instrumentation. |
src/usr/share/opentelemetry_shell/agent.instrumentation.github.actions.superlinter.sh
Outdated
Show resolved
Hide resolved
Add test for uninstrumented parallel execution with exported function.
Enable debugging for my_func in parallel execution test.
Removed my_func definition and related export from the test script.
moflwi
previously approved these changes
Mar 9, 2026
moflwi
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added integration job for Super Linter in GitHub Actions workflow.