Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the injection_deep_node demo artifacts to reflect a newly captured run/output of deep injection instrumentation.
Changes:
- Refreshed captured OTLP trace JSON, including updated SDK/instrumentation versions and additional DNS/TCP spans.
- Updated README sample output/“Full Trace” section to match the new trace content.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| demos/injection_deep_node/otlp.json | Updates the stored OTLP trace snapshot with new spans/attributes and newer OTel versions. |
| demos/injection_deep_node/README.md | Updates the documented sample trace output (now includes dns.lookup and tcp.connect and updated attributes). |
Comments suppressed due to low confidence (1)
demos/injection_deep_node/README.md:282
- The “Full Trace” block contains multiple JSON objects concatenated together, which is not valid JSON and is hard to copy/paste into tooling. Consider labeling this explicitly as NDJSON / "one JSON object per span" output, or wrapping the spans in a single JSON array (or adding clear separators) so readers don’t interpret it as a single JSON document.
plengauer
force-pushed
the
demos/injection_deep_node
branch
from
8ae77ad to
02ebc11
Compare
moflwi
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this PR is automatically generated)