Add Copilot coding agent subagents for shell instrumentation, tests, actions, packaging, and dependencies#3369
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/eb3fb1bc-4163-4b54-9f66-82668405bd02 Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
plengauer
April 15, 2026 12:40
View session
Owner
|
Hello, thanks for contributing for the first time! |
…lease skills Agent-Logs-Url: https://github.com/plengauer/Thoth/sessions/94d850d5-760e-426f-a710-dd7c3c04f92e Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
plengauer
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation “skills” that the Copilot coding agent can invoke, consolidating prior agent guidance into reusable checklists and adding new release/CI troubleshooting references.
Changes:
- Adds 7 new skill docs under
.github/skills/covering shell instrumentation, tests, Actions, packaging, dependencies, CI troubleshooting, and version/release process. - Documents repository-specific conventions (POSIX shell constraints, test runner behavior, workflow architecture, dependency sync requirements).
- Captures release/version automation rules and CI failure triage playbooks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/skills/writing-tests.md | Documents test layout, assert.sh usage, and conventions for span/log validation. |
| .github/skills/version-release.md | Describes VERSION-driven releases, workflows, and branching/tagging conventions. |
| .github/skills/updating-dependencies.md | Provides multi-ecosystem dependency update checklist and package metadata sync guidance. |
| .github/skills/shell-instrumentation.md | Specifies POSIX instrumentation rules (alias recursion avoidance, naming, dependency declarations). |
| .github/skills/packaging.md | Documents deb/rpm/apk synchronization rules and CI validation workflows. |
| .github/skills/github-actions.md | Documents workflow/action conventions, permissions, pinning, and instrumentation architecture. |
| .github/skills/ci-troubleshooting.md | Provides CI pipeline overview, common failures, and investigation steps. |
moflwi
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 specialized Copilot coding agent skills in
.github/skills/that the Copilot coding agent can invoke when working on issues and pull requests.The original 5 agents in
.github/agents/were re-evaluated and all converted to skills, plus 2 new skills were added.Skills vs Agents/Subagents — What is the difference?
.github/skills/).github/agents/)Why all 5 were converted to skills
All 5 original entries were domain knowledge that the agent applies inline during tasks, not autonomous delegatable work:
When would an agent be appropriate?
An agent would be justified if the repository had tasks that are: (1) fully self-contained, (2) complex enough to benefit from a separate context, and (3) frequently delegated. For this repository, tasks tend to be cross-cutting (code + tests + packaging), making skills the better fit.
Skills (7 total)
Transformed from agents (5)
shell-instrumentation.md_otel_/otel_namingwriting-tests.mdassert.shframework,resolve_span/resolve_log, SDK vs auto test patterns,$TEST_SHELLusagegithub-actions.mdobservability_workflow.ymlallowlistpackaging.mdupdating-dependencies.mdNew skills (2)
ci-troubleshooting.mdversion-release.mdHow to test
These are documentation-only files. No build or runtime validation needed.