Fix ubuntu-slim detection#3500
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the job-level instrumentation bootstrap to better detect GitHub ubuntu-slim runners (container-like environments) and adds workflow diagnostics to validate the detection across runner types.
Changes:
- Extend cgroup-based container detection to also match
containersinactions/instrument/job/inject_and_init.sh. - Expand the
Experimentworkflow’s runner matrix and add steps to print/.dockerenvand/proc/1/cgroupfor debugging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| actions/instrument/job/inject_and_init.sh | Broadens the cgroup regex to improve container/ubuntu-slim detection for the skip logic. |
| .github/workflows/experiment.yml | Adds runner variants and diagnostics to observe container markers/cgroup content. |
moflwi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.