Skip to content

Fix refresh demos workflow not triggering on nested demo files#3516

Merged
plengauer merged 4 commits into
mainfrom
copilot/fix-refresh-demos-workflow
May 26, 2026
Merged

Fix refresh demos workflow not triggering on nested demo files#3516
plengauer merged 4 commits into
mainfrom
copilot/fix-refresh-demos-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 25, 2026

The refresh_demos workflow path filter demos/*/* only matches files at exactly 2 levels deep, causing it to silently skip triggers when Renovate updates files nested deeper (e.g., demos/injection_deep_gradle/gradle/libs.versions.toml).

Changes

  • refresh_demos.yml: Replace demos/*/* with demos/** so all files at any depth under demos/ are considered; add !demos/README.md to exclude the manually-maintained top-level overview from triggering a run.
# Before
- 'demos/*/*'

# After
- 'demos/**'
- '!demos/README.md'

@plengauer
Copy link
Copy Markdown
Owner

Hello, thanks for contributing for the first time!

Copilot AI changed the title [WIP] Fix refresh demos workflow not triggering Fix refresh demos workflow not triggering on nested demo files May 25, 2026
Copilot AI requested a review from plengauer May 25, 2026 16:16
Copy link
Copy Markdown
Owner

@plengauer plengauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot thats not the issue. look at the logs. the issue is, that the release trigger triggers the workflows, but the if keeps the prep job from running. something is off.

…broke when publish.yml started passing commit SHA as target
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 25, 2026

@copilot thats not the issue. look at the logs. the issue is, that the release trigger triggers the workflows, but the if keeps the prep job from running. something is off.

You're right, sorry for the noise. The actual issue is that publish.yml was updated (in #3107) to pass --target "${{ matrix.ref }}" when creating releases, where matrix.ref is a commit SHA. This changed the release target_commitish from "main" to a value like "8a42906ace6a618a3b91545ef9b655b8c6d2ac23", so the condition github.event.release.target_commitish == 'main' became permanently false.

Fixed in the latest commit by dropping the target_commitish == 'main' check so prepare runs for any published release.

Copilot AI requested a review from plengauer May 25, 2026 16:26
@plengauer plengauer marked this pull request as ready for review May 26, 2026 12:09
@plengauer plengauer requested a review from moflwi as a code owner May 26, 2026 12:09
Copilot AI review requested due to automatic review settings May 26, 2026 12:09
@plengauer plengauer enabled auto-merge (squash) May 26, 2026 12:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@plengauer plengauer disabled auto-merge May 26, 2026 18:57
@plengauer plengauer enabled auto-merge (squash) May 26, 2026 18:57
@plengauer plengauer merged commit f7fe461 into main May 26, 2026
576 of 580 checks passed
@plengauer plengauer deleted the copilot/fix-refresh-demos-workflow branch May 26, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refresh demos workflow is not triggering anymore

4 participants