Fail report_failed_workflows job on hidden reporting pipeline errors

[Copilot]

The scheduled Report Failed Workflows job could complete successfully while still masking failures in the reporting pipeline. This update makes the step fail fast on real command/pipeline errors and simplifies parsing to reduce hidden failure modes.

• Fail-fast shell semantics

  • Updated the report_failed_workflows.yml run block to use set -euo pipefail so command, unset-variable, and pipeline failures correctly fail the step/job.

• Safer workflow parsing path

  • Replaced the base64 + nested jq decode flow with a single jq -r TSV output parsed directly in the shell loop.
  • This removes extra decode/parsing stages that could emit hidden errors while the job still appeared successful.

• Test scope correction

  • Removed the prior grep-only simulated unit test (tests/unit/test_unit_report_failed_workflows_uses_pipefail.sh) since it did not validate real behavior.

run: |
  set -euo pipefail
  gh api "/repos/${GITHUB_REPOSITORY}/actions/runs?per_page=100" | jq -r ...

[plengauer]

Hello, thanks for contributing for the first time!

[plengauer]

@copilot dont add simulated tests, add that to your memory!!!!
also, dont just add a pipefail, analyze the code and figure out whats wrong and fix it!

[Copilot]

@copilot dont add simulated tests, add that to your memory!!!!
also, dont just add a pipefail, analyze the code and figure out whats wrong and fix it!

Addressed in commit 0ea4781.

I removed the simulated grep-only test and updated the workflow logic itself: the step now uses set -euo pipefail and parses jq output directly as TSV in a single jq pass, eliminating the base64 + nested jq parsing path that could emit hidden errors without failing the job.

[Copilot]

Pull request overview

This PR hardens the scheduled “Report Failed Workflows” GitHub Actions job so it reliably fails when the reporting pipeline encounters real command/pipeline errors, reducing the chance of silently-successful runs that didn’t actually complete the reporting logic.

Changes:

• Enabled fail-fast shell behavior in the reporting step via set -euo pipefail.
• Simplified workflow-run parsing by switching from base64-encoded JSON objects to jq -r TSV output read directly by the shell loop.